Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages
Summary: Use Bootstrap "label" style for inline OPAC renewal messages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 12568
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-30 15:38 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages (85.93 KB, patch)
2014-08-01 19:23 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages (86.06 KB, patch)
2014-08-02 08:12 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages (86.15 KB, patch)
2014-08-02 19:31 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-30 15:38:50 UTC
Bug 12568 adds more prominent renewal messages to the OPAC user's list of checkouts. I would prefer that the messages be styled with a style which is better suited to an inline message. The "alert" style is more suited to block-level messages.

With some CSS tweaks the Bootstrap "label" style would work well I think:

http://getbootstrap.com/2.3.2/components.html#labels-badges
Comment 1 Owen Leonard 2014-08-01 19:23:15 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-08-02 08:12:01 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-02 19:31:12 UTC
Created attachment 30491 [details] [review]
[PASSED QA] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages

This patch revises the styling of the renewal success message to use a
default Bootstrap style more suited to inline messages. I think this is
preferable to using the alert style because the alert is designed to be
a block-level element.

http://getbootstrap.com/2.3.2/components.html#labels-badges

Because Koha's CSS already uses a "label" class for something else I
duplicate the Bootstrap "label" class in opac.css as "blabel." The
Bootstrap color definitions are included.

To test, follow the test plan already provided:

1) Apply this patch
2) From the OPAC, renew some items
3) Note the "Renewed!" message in the "Renew" column of the checkouts
   table

Patch works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Comment 4 Tomás Cohen Arazi 2014-08-03 20:39:47 UTC
Patch pushed to master.

Thanks Owen!