Bug 12636 - Batch patron modification should not update with unique patron attributes
Summary: Batch patron modification should not update with unique patron attributes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL: /cgi-bin/koha/tools/modborrowers.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-23 14:13 UTC by Owen Leonard
Modified: 2020-05-21 13:12 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12636: Do not display unique patron attributes in the batch patron modification (1.29 KB, patch)
2015-12-21 12:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12636: Do not display unique patron attributes in the batch patron modification (1.42 KB, patch)
2015-12-22 14:50 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12636: Do not display unique patron attributes in the batch patron modification (1.49 KB, patch)
2016-01-06 22:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12636: Do not display unique patron attributes in the batch patron modification (1.51 KB, patch)
2016-01-27 13:39 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-23 14:13:28 UTC
Batch patron modification should not offer to update patron attributes with values which are designated as unique since such attributes are required to be unique to a single patron.
Comment 1 Jonathan Druart 2015-12-21 12:33:48 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-22 14:50:39 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-01-06 22:43:47 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2016-01-27 13:39:00 UTC
Created attachment 47346 [details] [review]
Bug 12636: Do not display unique patron attributes in the batch patron modification

Batch patron modification should not offer to update patron attributes
with values which are designated as unique since such attributes are
required to be unique to a single patron.

Test plan:
Create some patron attributes, some should be unique.
Use the batch patron modification tool to modify patrons.
With this patch, the patron attributes marked as unique won't be
display anymore.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-01-27 21:00:13 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 6 Julian Maurice 2016-01-29 13:51:11 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 7 Frédéric Demians 2016-02-12 06:39:19 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.