To reproduce: - Create a patron attribute type that is repeatable, e.g. HOBBIES - Edit a patron and add multiple values of this type, e.g. Skating, Skiing, Swimming - Do a batch update for this patron with three values for the attribute, e.g. Reading, Jogging, Surfing - Go back to patron's detail page. - Result: Only one attribute is set (Surfing) (Expected: All 3 attributes are updated) - Restore the original values Skating, Skiing, Swimming Do the batch modification with one attribute only, e.g. Painting - Go back to patron's detail page - Result: Only one attribute is set (Painting) (Expected: Painting, Skiing, Swimming) Additionally, exclusive attributes can be repeated in batch update, result is similar as above (last attribute is taken). Expected: Exclusive attributes should not be repeatable in batch update.
Created attachment 45880 [details] [review] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore.
Created attachment 45883 [details] [review] [SIGNED-OFF] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors
Created attachment 46409 [details] [review] [PASSED QA] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master - Thanks
Note: this could be implemented.
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.