Bug 12642 - SMS.t requires a database
Summary: SMS.t requires a database
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks: 12657
  Show dependency treegraph
 
Reported: 2014-07-24 01:08 UTC by Robin Sheat
Modified: 2015-12-03 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12642 - move SMS.t to the db_dependant directory (476 bytes, patch)
2014-07-24 01:33 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 12642: t/SMS.t should not be db dependent (923 bytes, patch)
2014-07-25 09:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12642: t/SMS.t should not be db dependent (971 bytes, patch)
2014-07-28 03:54 UTC, Robin Sheat
Details | Diff | Splinter Review
[PASSED QA] Bug 12642: t/SMS.t should not be db dependent (1.05 KB, patch)
2014-07-28 06:01 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12642 - combined changelog updates for 3.16 (1.37 KB, patch)
2014-11-27 03:12 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2014-07-24 01:08:07 UTC
Needs to be moved to db_dependant or builds will be broken.
Comment 1 Robin Sheat 2014-07-24 01:33:56 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2014-07-25 03:37:39 UTC
This needs to happen for both master and 3.16.
Comment 3 Jonathan Druart 2014-07-25 09:03:05 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-07-25 09:03:31 UTC
Hi Robin, I proposed a counter patch, could you please have a look?
Comment 5 Robin Sheat 2014-07-28 03:54:12 UTC Comment hidden (obsolete)
Comment 6 Robin Sheat 2014-07-28 03:54:43 UTC
Looks good to me, and a better solution than mine.
Comment 7 Katrin Fischer 2014-07-28 06:01:02 UTC
Created attachment 30179 [details] [review]
[PASSED QA] Bug 12642: t/SMS.t should not be db dependent

SMS.t should not dependent on the DB.

Test plan:
verify that prove t/SMS.t returns green even if the DB is not there.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Turned off MySQL, tests still pass.
Comment 8 Tomás Cohen Arazi 2014-07-29 14:44:13 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 9 Robin Sheat 2014-11-27 03:12:34 UTC Comment hidden (obsolete)
Comment 10 Robin Sheat 2014-11-27 03:13:37 UTC
Comment on attachment 33969 [details] [review]
Bug 12642 - combined changelog updates for 3.16

That was not the right bug number.
Comment 11 Mason James 2015-01-27 20:48:59 UTC
Pushed to 3.16.x, patch will be in 3.16.8