Bug 12657 - PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts
Summary: PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Robin Sheat
QA Contact: Testopia
URL:
Keywords:
Depends on: 12642
Blocks: 11346
  Show dependency tree / graph
 
Reported: 2014-07-24 19:25 UTC by Owen Leonard
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12657 - remove references to prog and ccsr from the packages (6.23 KB, patch)
2014-07-25 04:12 UTC, Robin Sheat 		Details | Diff | Splinter Review
Bug 12657 - remove references to prog and ccsr from the packages (7.14 KB, patch)
2014-07-28 05:29 UTC, Robin Sheat 		Details | Diff | Splinter Review
Bug 12657 - remove references to prog and ccsr from the packages (7.20 KB, patch)
2014-09-17 21:54 UTC, Brendan Gallagher 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-07-24 19:25:04 UTC 
There are two scripts in debian/ which reference the deprecated opac-tmpl/prog and opac-tmpl/ccsr directories:

  debian/scripts/koha-translate
  debian/rules
Comment 1 Robin Sheat 2014-07-25 04:12:08 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2014-07-25 04:12:58 UTC 
I haven't given this extensive testing yet, just verified that it's possible to build a package from it. I'll look at it a bit closer next week unless someone beats me to it.
Comment 3 Robin Sheat 2014-07-28 05:29:54 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2014-09-17 21:54:31 UTC 
Created attachment 31686 [details] [review]
Bug 12657 - remove references to prog and ccsr from the packages

To test:
* Build a package and install it, and verify that there are no errors.
* Play around with koha-translate, listing, adding, and removing
  languages.

Note: one reference to prog and ccsr remains in koha-translate. This is
to allow it to remove any pre-existing translations on an upgrade.

Note 2: prog translations are still being installed, I think this is due
to the underlying translation system doing it.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 5 Chris Cormack 2014-09-23 05:08:04 UTC 
Pushed to MM_OPAC/theme_dep
Comment 6 Tomás Cohen Arazi (tcohen) 2014-10-30 00:48:01 UTC 
Patch merged into master.

Thanks Robin!