Bug 12666 - Offline Circulation has poor HTML
Summary: Offline Circulation has poor HTML
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-28 21:40 UTC by Mark Tompsett
Modified: 2015-06-04 23:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12666 - Fix poor HTML from circ/offline.tt (2.20 KB, patch)
2014-07-28 21:56 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12666 - Fix poor HTML from circ/offline.tt (2.30 KB, patch)
2014-08-01 16:01 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt (2.36 KB, patch)
2014-08-02 20:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2014-07-28 21:40:17 UTC
While attempting to generate a test plan for a patch for bug 10446 related to offline circulation, I noticed the HTML was poor. This cleans it up.
Comment 1 Mark Tompsett 2014-07-28 21:56:17 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-08-01 16:01:33 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-02 20:08:20 UTC
Created attachment 30495 [details] [review]
[PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt

In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
- Cleaned up the HTML's missing </div>'s
- Corrected the autobuffer attribute to the newer preload one
- Added &nbsp; into empty title, since it will get replaced

TEST PLAN
---------
1) Run the circ/offline.pl page source through an HTML validator
   -- should get a few warnings
2) Apply patch
3) Recheck page source (confirm your page isn't cached!)
   -- should be clean

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Improves HTML validity, no regressions found.
Comment 4 Tomás Cohen Arazi 2014-08-15 17:59:51 UTC
Patch pushed to master.

Thanks Mark!