After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this ctriterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories.
Created attachment 30568 [details] [review] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975
Created attachment 30608 [details] [review] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 30670 [details] [review] [PASSED QA] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found.
Patch pushed to master. Thanks Jacek!