Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration
Summary: Translations: Resolve ambiguity for word "checked" in Z39.50 server administr...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-07 15:25 UTC by Marc Véron
Modified: 2015-06-04 23:32 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12882 - Translations: Resolve ambiguity for word "checked" (3.22 KB, patch)
2014-09-07 17:05 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration (3.52 KB, patch)
2014-09-10 14:14 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration (3.60 KB, patch)
2014-09-10 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration (3.63 KB, patch)
2014-09-10 14:58 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2014-09-07 15:25:13 UTC
Based on comments in Bug 11285 (paxed and MV):

"Checked" - used in both suggestions and z3950 server list. In the z39.50 context, it means "chosen for search by default", IIRC, and in the suggestions it means the suggestion was "verified"
(http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285#c9)

...in German, that leads to "Geprüft" in z3950 server list (wrong!), should be something like "Standardsuche".
For suggestions, "Geprüft" would be OK.

It is impossible to resolve this in translations without changing the original wording.

See
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt

Patch follows.
Comment 1 Katrin Fischer 2014-09-07 15:33:29 UTC
Maybe we could use 'Selected' on the z39.50 configuration?
Comment 2 Marc Véron 2014-09-07 15:43:41 UTC
I would prefer "Search by default" in form for new targets and "Default search" as column heading.
Comment 3 Katrin Fischer 2014-09-07 15:45:11 UTC
Hm I think we need a native speaker to resolve :)
Comment 4 Marc Véron 2014-09-07 17:05:29 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2014-09-07 17:10:32 UTC
Note: Changing the word "Checked" in suggestions management would be much more complicated. That's why I restricted this patch on Z39.50 server administration to have a fast solution for wrong translations in this module.
Comment 6 Marcel de Rooy 2014-09-09 10:40:19 UTC
I would personally opt for "Select by default" rather than "Search by default".
Search by default may be more confusing.
Comment 7 Marcel de Rooy 2014-09-09 10:41:30 UTC
Another note: We still miss the signoff line from aleisha.
Comment 8 Marc Véron 2014-09-10 05:56:50 UTC
(In reply to M. de Rooy from comment #6)
> I would personally opt for "Select by default" rather than "Search by
> default".
> Search by default may be more confusing.

I asked for input on IRC channel:
http://irc.koha-community.org/koha/2014-09-09#i_1564999

Snippets:

oleonard:
"Active" as the table header and "Active (searched by default)" in the add/edit form

cait:
maybe selected? we use that for the checkboxes in tables
select all / unselect

gerundio: enabled?
oleonard: Enabled is good, for Z39.50 admin.
cait: i wonder if people will think it's to turn on/off the search option totally

mveron: Preselect for z39.50 admin?
cait: oh preselect is also nice

Note: 
Current patch has 
Table header: Default search
Form: Search by default
Comment 9 Marcel de Rooy 2014-09-10 11:04:09 UTC
(In reply to Marc Véron from comment #8)
> mveron: Preselect for z39.50 admin?
> cait: oh preselect is also nice

That sounds even better. Why not Preselect?

Note btw that changing strings because of translation limitations is imo not really ideal. It is a workaround; we probably should make changes to the translation process, which is of course much harder..
Comment 10 paxed 2014-09-10 11:19:08 UTC
(In reply to M. de Rooy from comment #9)
> 
> Note btw that changing strings because of translation limitations is imo not
> really ideal. It is a workaround; we probably should make changes to the
> translation process, which is of course much harder..

msgctxt
Comment 11 Marc Véron 2014-09-10 12:36:54 UTC
I copy M. de Rooy's comment about translating and paxed's hint for msgctxt () www.gnu.org/software/gettext/manual/html_node/Contexts.htmlto Bug 11285 because 11285 is a more generic bug regarding ambiguities and translations. 

msgctxt sounds interesting.
Comment 12 Marc Véron 2014-09-10 14:14:01 UTC Comment hidden (obsolete)
Comment 13 Marc Véron 2014-09-10 14:15:20 UTC
New patch with "Preselected", changed back to 'Needs Signoff'
Comment 14 Owen Leonard 2014-09-10 14:27:14 UTC Comment hidden (obsolete)
Comment 15 Jonathan Druart 2014-09-10 14:58:40 UTC
Created attachment 31510 [details] [review]
Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration

This patch resolves the ambiguity of the word "Checked" for Z39.50
server administration.

To test:
Apply patch
In staff client, go to Home:Administration:Z39.50/SRU servers
Result: Column heading of 6th column should show "Preselected" (instead
of "Checked")

Edit or create new server for Z39.50 and SRU
Result: Checkbox underneath "Password" should have label "Preselected
(searched by default):"

Click "Help" at top right of screen
Result: Wording changed for selecting targets as default.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 16 Tomás Cohen Arazi 2014-09-18 01:00:11 UTC
Patch pushed to master.

Thanks Marc!