Created attachment 31570 [details] [review] hotfix to this permission non-testing issue! when user doesn't have the permission. TO REPLICATE:: load circ/circulate.pl with a user with only the following permissions: circulate_remaining_permissions catalogue observe checkouts and holds not loading. Actually this crashes all javascript on the page!
Created attachment 31571 [details] [review] hotfix to this permission non-testing issue!
Created attachment 31575 [details] [review] [Signed-off] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable when user doesn't have the permission. TO REPLICATE:: load circ/circulate.pl with a user with only the following permissions: circulate_remaining_permissions catalogue observe checkouts and holds not loading. Actually this crashes all javascript on the page! Reproduced bug without patch. Applied patch, page displays as expected. Signed-off-by: Marc Véron <veron@veron.ch>
There is another similar issue in members/moremember.tt template (I'm not 100% sure it does affect 3.16.x branch as well - it most likely does, but I only eyeballed 3.16.x code to confirm this, without doing any actual tests in that branch).
I think this is almost a duplicate to bug 12878, but solving it differently. Kyle, could you take a look please?
*** This bug has been marked as a duplicate of bug 12878 ***
(In reply to Katrin Fischer from comment #4) > I think this is almost a duplicate to bug 12878, but solving it differently. > Kyle, could you take a look please? It is a duplicate. This patch only fixes circulation.pl while the other patch fixes both circulation.pl and moremember.pl. Kyle
Furthermore, I know there is a third duplicate on bugzilla somewhere that is also signed off. It will probably be the one to make it into master.
Any chance to clear up that mess a bit? :)
Don't push this push the other one. Clear enough?
Ok, it appears we have 3 patches for this - bug 12811 (pqa), bug 12920 and bug 12915) - and are probably going with 12811 plus follow-up.
Hmm, Bug 12915 seems to be not an exact duplicate (triplicate? ;) for Bug 12811 / Bug 12878; it has some additional good stuff in it, which is not included in 12811 nor in the followup in Bug 12920 (= fix for missing semicolon in koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc). Could we get strings.inc fix moved somewhere else (maybe to the separate bug report, if that would not be too much trouble ?) - I allready tested this fix, but after 12915 got marked as duplicate, there is no longer any place to sign it off..
Hi Jacek - thx for noticing :) Could you file a separate bug maybe? and link it to bug 12811 and the one we want to take the fix from?