Bug 12955 - The budget list always shows my funds
Summary: The budget list always shows my funds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 11578
Blocks: 12958 12988
  Show dependency treegraph
 
Reported: 2014-09-18 10:25 UTC by Jonathan Druart
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12955: The "show my funds only" should be take into account (1.27 KB, patch)
2014-09-18 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12955: The "show my funds only" should be take into account (1.34 KB, patch)
2014-09-18 19:04 UTC, Brendan Gallagher
Details | Diff | Splinter Review
[PASSED QA] Bug 12955: The "show my funds only" should be take into account (1.51 KB, patch)
2014-10-10 19:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-09-18 10:25:06 UTC
The "Show my funds only" is not take into account if the checkbox is not checked.
So there is no way to show all funds.
This has been introduced by bug 11578.
Comment 1 Jonathan Druart 2014-09-18 10:27:22 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-09-18 10:28:05 UTC
This is quite critical for 3.16.x branch.
Comment 3 Brendan Gallagher 2014-09-18 19:04:18 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-10-10 19:34:29 UTC
Created attachment 32198 [details] [review]
[PASSED QA] Bug 12955: The "show my funds only" should be take into account

The "Show my funds only" is not take into account if the checkbox is not
checked.
So there is no way to show all funds.
This has been introduced by bug 11578.

The default is not "only mine". The default is "show all funds".

Test plan:
- Create fund where you are the owner and others where you are not.
- Go on the fund list view and verify the checkbox "show my funds only"
  is take into account.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.

Note: In order to test this make sure you have funds owned by
another staff user.
Comment 5 Katrin Fischer 2014-10-27 23:08:16 UTC
My testing branch looked like this:
Bug 12988: Update table footer with the~
Bug 12955: The "show my funds only" should be take into account
Bug 12989: Fix JS error
Bug 12989: Update table footer with the visible rows - acqui-home
Bug 12984: Improvement of the funds list view - acqui home
Bug 12987: The new format_price include file should be include on using...
Bug 12987: Update table footer with the visible rows
Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2)
<master> Bug 12844: Force the symbol place in the tests
Comment 6 Tomás Cohen Arazi 2014-10-31 19:42:58 UTC
Patch pushed to master.

Thanks Jonathan!