On editing a fund, it would facilitate to have the ability to select a owner for all the fund hierarchy.
Created attachment 31701 [details] [review] Bug 12958: Set a fund owner to a fund hierarchy This patch adds the ability to set an owner to a fund hierarchy On editing a fund, if it has children, a new checkbox appears "Set this owner to all children funds". If checked, all the fund hierarchy will herit to this owner. This will facilitate the fund owner modifications. Test plan: - Verify that the new checkbox only appears if the fund has at least a child. - Create a consistent fund hierarchy, something like: fund1 fund11 fund111 fund12 fund2 fund21 - Try to modify a fund owner without checking the checkbox. Verify the children have not been modified. - Try to modify a fund owner with checking the checkbox. Verify all fund hierarchy has been modified.
Note that this patch does not depend on bug 12955 and bug 12956 but I recommend to test the enhancement with these bug fixes applied.
Created attachment 32790 [details] [review] Bug 12958 Followup, more 'gracious' UI? Rewording: Set this owner to all children funds becomes: Propagate to children funds And put the checkbox on the same line Than Owner: rather than on the next line.
Created attachment 32791 [details] [review] Bug 12958: Set a fund owner to a fund hierarchy This patch adds the ability to set an owner to a fund hierarchy On editing a fund, if it has children, a new checkbox appears "Set this owner to all children funds". If checked, all the fund hierarchy will herit to this owner. This will facilitate the fund owner modifications. Test plan: - Verify that the new checkbox only appears if the fund has at least a child. - Create a consistent fund hierarchy, something like: fund1 fund11 fund111 fund12 fund2 fund21 - Try to modify a fund owner without checking the checkbox. Verify the children have not been modified. - Try to modify a fund owner with checking the checkbox. Verify all fund hierarchy has been modified. Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as announced.
Note: patches 12956 & 12955 are required to apply this one. Jonathan: You are the best placed to see if my UI rewording has any intersest.
Owen, could you take a look at the first = second GUI follow-up? I wonder if we should add a warning, that if the child funds already have an owner, this one will be overwritten.
Created attachment 32822 [details] [review] Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy This alternate follow-up modifies the text of the label to (hopefully) make it more clear. The markup has been revised someone to make it more standard, and a warning has been added about overwriting existing data.
Created attachment 32846 [details] Owen layout scrrenshot Owen alt follow-up looks good to me. I obsolete mine, and sign his.
Created attachment 32847 [details] [review] Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy This alternate follow-up modifies the text of the label to (hopefully) make it more clear. The markup has been revised someone to make it more standard, and a warning has been added about overwriting existing data. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Looks good.
Created attachment 32855 [details] [review] [PASSED QA] Bug 12958: Set a fund owner to a fund hierarchy This patch adds the ability to set an owner to a fund hierarchy On editing a fund, if it has children, a new checkbox appears "Set this owner to all children funds". If checked, all the fund hierarchy will herit to this owner. This will facilitate the fund owner modifications. Test plan: - Verify that the new checkbox only appears if the fund has at least a child. - Create a consistent fund hierarchy, something like: fund1 fund11 fund111 fund12 fund2 fund21 - Try to modify a fund owner without checking the checkbox. Verify the children have not been modified. - Try to modify a fund owner with checking the checkbox. Verify all fund hierarchy has been modified. Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as announced. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 32856 [details] [review] [PASSED QA] Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy This alternate follow-up modifies the text of the label to (hopefully) make it more clear. The markup has been revised someone to make it more standard, and a warning has been added about overwriting existing data. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Looks good. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script.
Patches pushed to master. Thanks Jonathan and Owen!