OpacMainUserBlockMobile is still pushed as a parameter in C4::Auth. This generates a noisy warning. This patch will remove the parameter in question.
Created attachment 33223 [details] [review] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools
Created attachment 33224 [details] [review] [SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Super Simple Patch.. works as expected :)
Created attachment 33249 [details] [review] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Mark!