Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm
Summary: Followup of Bug 12246 - noisy C4/Auth.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on: 12246
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-05 08:01 UTC by Mark Tompsett
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm (1.79 KB, patch)
2014-11-05 08:14 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm (1.87 KB, patch)
2014-11-05 08:31 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm (1.92 KB, patch)
2014-11-05 15:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2014-11-05 08:01:07 UTC
OpacMainUserBlockMobile is still pushed as a parameter in C4::Auth. This generates a noisy warning. This patch will remove the parameter in question.
Comment 1 Mark Tompsett 2014-11-05 08:14:19 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2014-11-05 08:31:51 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2014-11-05 08:32:56 UTC
Super Simple Patch.. works as expected :)
Comment 4 Jonathan Druart 2014-11-05 15:30:09 UTC
Created attachment 33249 [details] [review]
Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm

While testing a bug, warnings in the opac error log were
building up due to a particular line in C4::Auth. After
reviewing the code, it was discovered that removal of the
OpacMainUserBlockMobile system preference created this.

Since the system preference no longer exists, and is not
used, the line was deleted from C4/Auth.pm to prevent this
warning from occuring.

TEST PLAN
----------
1) Go to any OPAC page.
2) Check your opac error log.
   -- there should be something about uninitialized values
      used in C4/Auth.pm around line 443.
3) Apply the patch
4) Refresh the page.
   -- that same error should not be triggered.
5) prove -v t/db_dependent/Auth.t
   -- this runs the get_template_and_user function
      which had the parameter removed.
6) run the koha qa test tools

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Tomás Cohen Arazi 2014-11-07 18:22:09 UTC
Patch pushed to master.

Thanks Mark!