Some more datatables have broken paging - fixes will be similar to those on bug 13487.
Created attachment 36112 [details] [review] Bug 13744: Fix datatables paging on 'order from subscription' page The paging of the datatable on the 'order from subscription' page is broken without this patch. To test: - Make sure you have a subscription, note the vendor - Create a new basket for this vendor - Add a new order line 'from a subscription' - Check paging on the result table displays correctly
Created attachment 36113 [details] [review] Bug 13744: Fix datatables paging on 'Holds to pull' report The paging of the datatables on the 'holds to pull' report page is broken without this patch. To test: - Make sure that some holds are placed on available items in your installation - Go to the circulation start page - Open the 'holds to pull' report - Verify that the patch fixes the paging on the result table
Created attachment 36117 [details] [review] Bug 13744: Fix datatables paging on 'checkout history' page The paging in the datatable on the 'circulation history' page is broken without this patch. /cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=... To test: - Search for a record with items that have been checked out in the past - From the detail page, open the 'checkout history' tab - Check paging displays correctly with this patch and is broken without
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 40) from the qa script
Good catch :)
Created attachment 36347 [details] [review] Bug 13744: Fix datatables paging on 'Holds to pull' report The paging of the datatables on the 'holds to pull' report page is broken without this patch. To test: - Make sure that some holds are placed on available items in your installation - Go to the circulation start page - Open the 'holds to pull' report - Verify that the patch fixes the paging on the result table Also: Fixes "None" in the filter pull downs to be translatable.
Created attachment 36381 [details] [review] [SIGNED-OFF] Bug 13744: Fix datatables paging on 'order from subscription' page The paging of the datatable on the 'order from subscription' page is broken without this patch. To test: - Make sure you have a subscription, note the vendor - Create a new basket for this vendor - Add a new order line 'from a subscription' - Check paging on the result table displays correctly Signed-off-by: Nicole <nicole@bywatersolutions.com>
Created attachment 36382 [details] [review] [SIGNED-OFF] Bug 13744: Fix datatables paging on 'checkout history' page The paging in the datatable on the 'circulation history' page is broken without this patch. /cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=... To test: - Search for a record with items that have been checked out in the past - From the detail page, open the 'checkout history' tab - Check paging displays correctly with this patch and is broken without Signed-off-by: Nicole <nicole@bywatersolutions.com>
Created attachment 36385 [details] [review] [SIGNED-OFF] Bug 13744: Fix datatables paging on 'Holds to pull' report The paging of the datatables on the 'holds to pull' report page is broken without this patch. To test: - Make sure that some holds are placed on available items in your installation - Go to the circulation start page - Open the 'holds to pull' report - Verify that the patch fixes the paging on the result table Also: Fixes "None" in the filter pull downs to be translatable. Signed-off-by: Nicole <nicole@bywatersolutions.com>
Created attachment 36472 [details] [review] Bug 13744: Fix datatables paging on 'order from subscription' page The paging of the datatable on the 'order from subscription' page is broken without this patch. To test: - Make sure you have a subscription, note the vendor - Create a new basket for this vendor - Add a new order line 'from a subscription' - Check paging on the result table displays correctly Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 36473 [details] [review] Bug 13744: Fix datatables paging on 'checkout history' page The paging in the datatable on the 'circulation history' page is broken without this patch. /cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=... To test: - Search for a record with items that have been checked out in the past - From the detail page, open the 'checkout history' tab - Check paging displays correctly with this patch and is broken without Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 36474 [details] [review] Bug 13744: Fix datatables paging on 'Holds to pull' report The paging of the datatables on the 'holds to pull' report page is broken without this patch. To test: - Make sure that some holds are placed on available items in your installation - Go to the circulation start page - Open the 'holds to pull' report - Verify that the patch fixes the paging on the result table Also: Fixes "None" in the filter pull downs to be translatable. Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patches pushed to master. Thanks Katrina!
Pushed to 3.18.x will be in 3.18.5
Possible selection for 3.16.x
Pushed to 3.16.x, will be in 3.16.10