On acqui/basketgroup.pl and catalogue/itemsearch.pl, the sPaginationType DT parameter is not explicitly defined. This broken the pagination display. Moreover, since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST").
Created attachment 34626 [details] [review] Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed.
Created attachment 34627 [details] [review] Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled.
Created attachment 34628 [details] [review] Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled.
(In reply to Jonathan Druart from comment #1) > Created attachment 34626 [details] [review] [review] > Bug 13487: DT pagination contains '...' for the full_numbers form This is certainly not the best way to fix that. Feel free to suggest something else.
Let me know if you found other pagination problems.
Created attachment 34683 [details] [review] Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 34684 [details] [review] Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 34685 [details] [review] Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 34703 [details] [review] [PASSED QA] Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34704 [details] [review] [PASSED QA] Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34705 [details] [review] [PASSED QA] Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.3