Bug 13774 - Add the unique anchors of news as links in the RSS for news in Opac
Summary: Add the unique anchors of news as links in the RSS for news in Opac
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 5010
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-02 11:30 UTC by Viktor Sarge
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac (1.62 KB, patch)
2015-03-02 13:50 UTC, Viktor Sarge
Details | Diff | Splinter Review
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac (1.79 KB, patch)
2015-12-31 14:57 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac (1.85 KB, patch)
2016-01-04 11:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Viktor Sarge 2015-03-02 11:30:31 UTC
Bug 7843 introduces an RSS stream for news (currently passed QA) which is valid but don't have a good unique URI of each newsitem for linking purposes. Bug 12729 (pushed) creates unique a unique anchor id for each newsitem and I propose to update the RSS stream with links to these anchors as a first step. The next step would be to create some form of single item view for news and probably a news archive instead of deleting the news when they time out.
Comment 1 Viktor Sarge 2015-03-02 13:50:30 UTC Comment hidden (obsolete)
Comment 2 Pierre Angot 2015-03-03 16:19:00 UTC
I've tested on sandbox.

I've added the RSS on my agregator (Leed). It works correctly, but when I click on a link, I'm not direct to the opac.
Comment 3 Viktor Sarge 2015-05-12 09:33:00 UTC
Hi Pierre! We discovered that the sandboxes has the opac disabled as public. The RSS stream does link to the correct news item but when the opac require log in you will not be able to see the news. Does the problem persist when you make the opac public in the sysprefs? 

Another thing to watch our for is that the RSS stream can only expose news that are directed to "all libraries". If you view the news while logged in and only have news directed to a particular library (but none directed to "all libraries" you will get an empty RSS. This need to be handled a bit better, but that's a matter for other patches :)
Comment 4 Mark Tompsett 2015-05-15 05:30:15 UTC
I added depends on 5010, because there is no hardcoded protocol in this link, which means it will be protocol-less currently.
Comment 5 Viktor Sarge 2015-06-18 11:59:45 UTC
We plan to add the ability to pass the id of a news item to (for example) opac-main.pl and if that gets pushed it will likely be better to add this link instead of anchors. But it will still depend on 5010 i guess.
Comment 6 Marc Véron 2015-12-31 14:57:55 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-01-04 11:57:49 UTC
Created attachment 46227 [details] [review]
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac

This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843.
Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change.

The addition of a unique guid tag both help users and keeps validators happy.

Test plan:
* Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually).
* Apply bug 7843
* Apply this patch.
* Make shure you have enough news to make the Opac main page scroll.
* Find the RSS link at the bottom om opac main and klick it.
* Verify that the link displayed for each newsitem takes you to the right anchor.

Followed test plan, works as expected. Signed-off-by: Marc Véron
<veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Kyle M Hall 2016-01-04 12:46:32 UTC
Pushed to master, thanks Viktor!