When editing or adding a numbering pattern in the serials module the pull down for subscription length shows issues, weeks, months. These always appear in English and seem to be untranslatable. Looking at the same pull down on the second page of the "new subscription" form, the values properly translate there. Figuring out the difference in the templates that makes one translatable but not the other would be good. For installing translations: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client For updating the po files to test a fix, see test plan of bug 25067.
The following change should work @ koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt:182 @ <li> <label for="sublength">Subscription length:</label> <select id="subtype"> - [% FOREACH subtype IN subtypes_loop %] - <option value="[% subtype.value | html %]">[% subtype.value | html %]</option> - [% END %] + <option value="issues">issues</option> + <option value="weeks">weeks</option> + <option value="months">months</option> (I missed the Academy keyword!)
Created attachment 115475 [details] [review] Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone.
Created attachment 115631 [details] [review] Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx, fixing issues with translations always makes me happy!
Previous comment was for another bug!
Created attachment 116196 [details] [review] Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work, this is a great little improvement. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.