Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work
Summary: Accessibility: Searching patrons using the alphabetic index doesn't work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 15603
  Show dependency treegraph
 
Reported: 2015-05-13 08:46 UTC by Katrin Fischer
Modified: 2017-01-10 19:37 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work (3.41 KB, patch)
2016-01-19 16:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work (3.43 KB, patch)
2016-01-19 21:05 UTC, Briana Greally
Details | Diff | Splinter Review
[PASSED QA] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work (3.49 KB, patch)
2016-01-19 22:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-05-13 08:46:36 UTC
It's not possible to use the alphabetic index search using only the keyboard.

The librarian reporting this is using braille line, screenreader and keyboard for navigating and using Koha. 

After selecting a character from the alphabetic index list and pressing enter to trigger the feature, the table of patrons is loaded, but it always shows 'no results found', even if there are patrons for that letter in the database.
Comment 1 Katrin Fischer 2016-01-18 00:07:00 UTC
This is a bit tricky, but maybe someone has an idea :)
Comment 2 Owen Leonard 2016-01-19 16:46:47 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2016-01-19 19:17:40 UTC
Owen,

I applied the patch and cleared my cache, but the tab is not going to the letters.

Did I miss something? I'm in Firefox on Mac

Nicole
Comment 4 Briana Greally 2016-01-19 21:05:34 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-01-19 22:11:01 UTC
Created attachment 46948 [details] [review]
[PASSED QA] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work

Using a mouse to click on the alphabetic index letters works even though
the anchor markup doesn't contain an href attribute. However you
can't tab to them using the keyboard, and I assume the issue with
screen readers is related.

This patch adds a dummy href attribute and a class-based click handler
so that we can get rid of the "onclick" attribute in the markup.

To test, apply the patch and visit the "Patrons" section.

1. Use the tab key to move the focus to one of the alphabet links.
2. Hit "Enter" and confirm that the search is performed correctly.
3. Click any of the alphabet links and confirm that clicking works as
   well.
4. View the details of any patron and click the "Add child" button.
5. In the "Guarantor information" section click the "Change" button.
6. In the search popup, use the tab key to move the focus to one of the
   alphabet links.
2. Hit "Enter" and confirm that the search is performed correctly.
3. Click any of the alphabet links and confirm that clicking works as
   well.

Signed-off-by: Briana <brianagreally@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2016-01-19 22:11:33 UTC
Thx a lot for this, I had no idea where to start!
Comment 7 Brendan Gallagher 2016-01-23 19:02:41 UTC
Pushed to Master - Should be in the May 2016 release.  - Thanks!
Comment 8 Julian Maurice 2016-01-25 11:51:40 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 9 Frédéric Demians 2016-01-25 16:28:00 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.