When editing a budget, owners or users are selected from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Select" link. I assume this is because, like the problem in Bug 15602, the link has no href attribute.
Created attachment 46965 [details] [review] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit
Created attachment 46966 [details] [review] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips select. 7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard.
Just noticed we created another bug, don't test this patch yet.
our mistake, you need to apply the patch from bug 14193 before this patch.
*** Bug 15604 has been marked as a duplicate of this bug. ***
Created attachment 47084 [details] [review] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips select. 7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Hi Natasha, I followed your test plan, and with bug 14193 applied before, it works as expected.
Created attachment 47175 [details] [review] [PASSED QA] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips select. 7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.