Typo in help file from the new help in Koha 3.20, bug 14424: intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28 It reads: (The match will look at the itemnumbers and barcodes to match on for items. Itemnumbers take precendence over barcodes), typo: precendence
Created attachment 41044 [details] [review] Bug 14545 - Typo in help file (stage-marc-import.tt) Typo found in stage-marc-import.tt file for Koha help in 3.20 Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28' and check the typo "precendence" or go to Tools > Stage MARC records for import and open up the help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador
That entire line appears to be deleted from the page when I apply this patch?
(In reply to Aleisha Amohia from comment #2) > That entire line appears to be deleted from the page when I apply this patch? Yes, you're right, I will fix this! Regards
Something happened when editing the file: This is the screen when looking for differences diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-impor index 422501b..327230f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt @@ -25,7 +25,7 @@ <li>Finally choose what to do with records that are unique</li> <li>Next you can choose whether or not to import the item data found in the <ul> - <li>From here you can choose to always add items regardless of matching stat + <li>From here you can choose to always add items regardless of matching stat </ul> </li> <li>Click 'Stage for import'</li> @@ -37,4 +37,4 @@ <p><strong>See the full documentation for the MARC Import in the <a href="http: -[% INCLUDE 'help-bottom.inc' %] \ No newline at end of file +[% INCLUDE 'help-bottom.inc' %] I didn't edit the INCLUDE declaration I will send the commit again
Created attachment 41074 [details] [review] Bug 14545 - Typo in help file (stage-marc-import.tt) Typo found in stage-marc-import.tt file for Koha help in 3.20 Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28' and check the typo "precendence" or go to Tools > Stage MARC records for import and open up the help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador
(In reply to Héctor Eduardo Castro Avalos from comment #5) > Created attachment 41074 [details] [review] [review] > Bug 14545 - Typo in help file (stage-marc-import.tt) Hi, Aleisha I applied this new patch and works for me. Regards
Created attachment 41089 [details] [review] Bug 14545 - Typo in help file (stage-marc-import.tt) Typo found in stage-marc-import.tt file for Koha help in 3.20 Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28' and check the typo "precendence" or go to Tools > Stage MARC records for import and open up the help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 41144 [details] [review] [PASSED QA] Bug 14545 - Typo in help file (stage-marc-import.tt) Typo found in stage-marc-import.tt file for Koha help in 3.20 Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28' and check the typo "precendence" or go to Tools > Stage MARC records for import and open up the help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. ¡Gracias Hector!
Pushed to 3.20.x will be in 3.20.3