On opac-detail, when a user is not logged in, with Tags enabled, you've got both : - a link "Add tag(s)" that does nothing - a comment "Log in to add tags." We would expect only the comment in this case, and the link when the user is logged-in
That is silly. I think "Add tag(s)" is good to have visible in the same place as when it's actually usable. What about "Add tag(s) - requires login"? Ideally that would give a login dialog and then do the normal behavior without leaving the page. Then we keep the same workflow while logged in/not logged in. I'll see if anyone in my team can have a look.
Created attachment 49396 [details] [review] Bug 14582 - OPAC detail shows an unuseful link to "add tag" when user is not logged in This patch rearranges some parts of the OPAC detail page template so that the "add tag" link does not appear if the user is not logged in. This patch also includes some whitespace changes, so please diff accordingly. To test, apply the patch and set "TagsEnabled" to "Allow." - With "TagsInputOnDetail" set to "Allow," view the detail page for a bibliographic record in the OPAC when /not/ logged in. You should see a "Log in to add tags" link which triggers the login modal when clicked. - Log in and view the same page. Confirm that there is now an "Add tag(s)" link which triggers the add tags form. Confirm that the behavior of the add tags form is still correct. - With "TagsInputOnDetail" set to "Don't allow" view the detail page again and verify that the "Log in to add tags" link doesn't appear when not logged in, and the "Add tags" link doesn't appear when logged in.
Created attachment 49431 [details] [review] Bug 14582 - OPAC detail shows an unuseful link to "add tag" when user is not logged in This patch rearranges some parts of the OPAC detail page template so that the "add tag" link does not appear if the user is not logged in. This patch also includes some whitespace changes, so please diff accordingly. To test, apply the patch and set "TagsEnabled" to "Allow." - With "TagsInputOnDetail" set to "Allow," view the detail page for a bibliographic record in the OPAC when /not/ logged in. You should see a "Log in to add tags" link which triggers the login modal when clicked. - Log in and view the same page. Confirm that there is now an "Add tag(s)" link which triggers the add tags form. Confirm that the behavior of the add tags form is still correct. - With "TagsInputOnDetail" set to "Don't allow" view the detail page again and verify that the "Log in to add tags" link doesn't appear when not logged in, and the "Add tags" link doesn't appear when logged in. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 49468 [details] [review] Bug 14582 - OPAC detail shows an unuseful link to "add tag" when user is not logged in This patch rearranges some parts of the OPAC detail page template so that the "add tag" link does not appear if the user is not logged in. This patch also includes some whitespace changes, so please diff accordingly. To test, apply the patch and set "TagsEnabled" to "Allow." - With "TagsInputOnDetail" set to "Allow," view the detail page for a bibliographic record in the OPAC when /not/ logged in. You should see a "Log in to add tags" link which triggers the login modal when clicked. - Log in and view the same page. Confirm that there is now an "Add tag(s)" link which triggers the add tags form. Confirm that the behavior of the add tags form is still correct. - With "TagsInputOnDetail" set to "Don't allow" view the detail page again and verify that the "Log in to add tags" link doesn't appear when not logged in, and the "Add tags" link doesn't appear when logged in. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!