If you send yourself a cart from the OPAC or staff client, multiple URLs are displayed, but without a space or new line - so they appear as one big broken link. This is the case for staff and OPAC cart emails. Also: it includes non-HTTP-URLs that might not be clickable at all (like URNs in a separate 856).
*** Bug 11049 has been marked as a duplicate of this bug. ***
For electronic resources this is quite a problem :(
Created attachment 49527 [details] [review] Bug 14614: Multiple URLs (856) in cart/list email are broken To reproduce: - Add multiple subfields 856 u to a bilbio - Add this biblio to a cart and send it as mail Result: Links in mail body are broken To test - Apply patch - Send cart again - Result: In mail body, links display separated with blank-pipe-blank like http://bla.com | http://blabla.com | http://blablabla.com - Change one of the 856 u to not to be a link, e.g. äöü - Send cart again - Verify that in mail body äöü correctly display as text.
This looks good in the staff client, but in the OPAC the URLs are not separated by a "|" or even a space.
Created attachment 49529 [details] [review] Bug 14614: Multiple URLs (856) in cart/list email are broken To reproduce: - Add multiple subfields 856 u to a bilbio - Add this biblio to a cart and send it as mail (from Staff client and from OPAC) Result: Links in mail body are broken To test - Apply patch - Send carts again (from Staff client and from OPAC) - Result: In mail body, links display separated with blank-pipe-blank like http://bla.com | http://blabla.com | http://blablabla.com - Change one of the 856 u to not to be a link, e.g. äöü - Send carts again - Verify that in mail body äöü correctly display as text. (Amended to make it work for OPAC as well, MV)
Created attachment 49530 [details] [review] [SIGNED-OFF] Bug 14614: Multiple URLs (856) in cart/list email are broken To reproduce: - Add multiple subfields 856 u to a bilbio - Add this biblio to a cart and send it as mail (from Staff client and from OPAC) Result: Links in mail body are broken To test - Apply patch - Send carts again (from Staff client and from OPAC) - Result: In mail body, links display separated with blank-pipe-blank like http://bla.com | http://blabla.com | http://blablabla.com - Change one of the 856 u to not to be a link, e.g. äöü - Send carts again - Verify that in mail body äöü correctly display as text. (Amended to make it work for OPAC as well, MV) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 49532 [details] [review] Bug 14614: Multiple URLs (856) in cart/list email are broken To reproduce: - Add multiple subfields 856 u to a bilbio - Add this biblio to a cart and send it as mail (from Staff client and from OPAC) Result: Links in mail body are broken To test - Apply patch - Send carts again (from Staff client and from OPAC) - Result: In mail body, links display separated with blank-pipe-blank like http://bla.com | http://blabla.com | http://blablabla.com - Change one of the 856 u to not to be a link, e.g. äöü - Send carts again - Verify that in mail body äöü correctly display as text. (Amended to make it work for OPAC as well, MV) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to Master - Should be in the May 2016 release. Thanks!
Thx a lot for fixing this!
Patch pushed to 3.22.x, will be in 3.22.6
Pushed to 3.20.x, will be in 3.20.11.