Same bug as bug 14614, but for list emails send from staff and intranet. If there are multiple URLs (865 fields), the URLs get squashed together into 'one URL' in the email sent and are broken therefore. Same fix as for the other bugs should work nicely here.
Created attachment 59111 [details] [review] Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work
Hi Caitlin, this is good, but can you please take a look at the corresponding file for the OPAC (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt)? It needs the same fix and I could then test and sign-off on both fixes together. Thx!
Created attachment 59197 [details] [review] Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work
Created attachment 59527 [details] [review] [SIGNED-OFF] Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 59528 [details] [review] [SIGNED-OFF] Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 60462 [details] [review] Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 60463 [details] [review] Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Caitlin!
These patches have been pushed to 16.11.x and will be in 16.11.04. Thx Caitlin!
Bug, not enhancement :)
Pushed to 16.05.x, for 16.05.10 release
Pushed to 3.22.x, will be in 3.22.18