The Search Patrons box at the top of import_borrowers.pl has a + sign so you can reveal the extra options to search by library and/or categorycode. All that happens when you click on the [+] link, the [+] changes to a [-], and vice versa. No extra line is revealed. Test plan: 1.) Go to Tools --> Import Patrons. 2.) Click on the Search Patrons box (if it isn't activated already). 3.) Click on the [+] link next to the search box. 4.) Note that it changes to [-], but no extra line is revealed.
This is not an issue in 3.20, because of bug 13235. I'm about to attach a modified version of the patch for 3.18.
Created attachment 41646 [details] [review] Bug 14690 - [3.18.x] Patron import tool page missing extra search patron options To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Also please be sure to check the patron import page. Owen is listed as the author of this, because that's mostly true - I just resolved the conflict for 3.18.x (LR)
This is also an issue for bug 13628. Would this patch fix that bug, too?
I'm not seeing this problem. I do see lines appear when I click the + before applying this patch.
The patch for 13628 is in 3.18.11, and would fix this problem.
That is, this patch is in 3.18.11.