Bug 14690 - Patron import tool page missing extra search patron options
Summary: Patron import tool page missing extra search patron options
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.18
Hardware: All All
: P5 - low minor (vote)
Assignee: Liz Rea
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 20:32 UTC by HB-NEKLS
Modified: 2016-06-21 21:37 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14690 - [3.18.x] Patron import tool page missing extra search patron options (13.35 KB, patch)
2015-08-19 03:31 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description HB-NEKLS 2015-08-18 20:32:18 UTC
The Search Patrons box at the top of import_borrowers.pl has a + sign so you can reveal the extra options to search by library and/or categorycode. 

All that happens when you click on the [+] link, the [+] changes to a [-], and vice versa. No extra line is revealed. 

Test plan: 
1.) Go to Tools --> Import Patrons. 
2.) Click on the Search Patrons box (if it isn't activated already). 
3.) Click on the [+] link next to the search box.
4.) Note that it changes to [-], but no extra line is revealed.
Comment 1 Liz Rea 2015-08-19 03:27:24 UTC
This is not an issue in 3.20, because of bug 13235. I'm about to attach a modified version of the patch for 3.18.
Comment 2 Liz Rea 2015-08-19 03:31:11 UTC
Created attachment 41646 [details] [review]
Bug 14690 - [3.18.x] Patron import tool page missing extra search patron options

To test, apply the patch and navigate to the Patrons home page. Expand
the hidden search fields in the search header and confirm that the
layout looks correct. Perform some searches and check that the results
are correct and that the modified search fields retain their state.

Also please be sure to check the patron import page.

Owen is listed as the author of this, because that's mostly true - I just resolved the conflict for 3.18.x (LR)
Comment 3 HB-NEKLS 2015-10-13 16:36:18 UTC
This is also an issue for bug 13628. Would this patch fix that bug, too?
Comment 4 Nicole C. Engard 2015-10-30 19:54:27 UTC
I'm not seeing this problem.  I do see lines appear when I click the + before applying this patch.
Comment 5 Liz Rea 2015-11-02 21:27:33 UTC
The patch for 13628 is in 3.18.11, and would fix this problem.
Comment 6 Liz Rea 2015-11-02 21:28:03 UTC
That is, this patch is in 3.18.11.