This is what currently happens: - Unset AnonymousPatron - Set a patrons history to "never" - Check in an item from this patron's account - It should show an error message, but the item will still be listed in the list of checked-in items We should only show an error message or at least a helpful note that the item has not really been returned in the table below. There might be other cases where this happens - so could be a more general fix is needed.
Created attachment 42548 [details] [review] Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode.
Created attachment 44054 [details] [review] Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm that the checkin table hasn't to be populated with info on items which haven't been checked in.
Created attachment 44247 [details] [review] [PASSED QA] Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm that the checkin table hasn't to be populated with info on items which haven't been checked in. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
This patch has been pushed to 3.20.x, will be in 3.20.6.