For some libraries, the checked-in items list operates more as a 'transaction list' and the ability to check in an item to see it's status, or to see which items from a stack have been checked in, etc. is necessary for daily workflow. Bug 14821 removed all items from list that weren't checked out - there should be a system preference to determine this behaviour (and I would argue showing them would be the default)
Do you have a suggestion for the pref name?
In IRC: I suggested: HideItemsNotCheckedIn or DisplayAllItemScannedAtCheckin cait: suggested: ShowAllCheckins I think any would be fine but I think libraries will want this soon and a name change is always possible if we don't like it later
I just want to add my two cents in on this that for our consortia, where we're transferring lots of items in and out, libraries are used to seeing these items listed. It's critical for our operations at 50 libraries to have this list of items enabled. I have no preference on what it's called.
Since bug 14821 is in 3.20 and 3.22, what should be considered the default behavior?
Jonathan, I guess if bug 14821 has been in 3.20 and 3.22 for awhile, the default behavior would need to be the current behavior of the software, which is not showing this list. That's the common practice, right?
Created attachment 48122 [details] [review] Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed
Created attachment 48123 [details] [review] Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed
Created attachment 48124 [details] [review] Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 48144 [details] [review] Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 48145 [details] [review] Bug 15736 [QA Followup] - Make add more details to the syspref description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I know Kyle has already passed QA, but at Nick's encouragement, I put this on a sandbox and gave it a second look, following the test plan. Everything looks good. Thanks Jonathan, so much, for getting this written. You have my many thanks today for this and saved me lots of grief with all my librarians when we upgrade in less than two weeks to 3.22.
pushed to master - should be in the May 2016 release. thanks
*just a note - I am in the process of adding the DBrev - but I have to step away for like 30 minutes - this is to make sure I come back and finish that part :).
Completed. (In reply to Brendan Gallagher from comment #13) > *just a note - I am in the process of adding the DBrev - but I have to step > away for like 30 minutes - this is to make sure I come back and finish that > part :).
Patches pushed to stable, will be in 3.22.5
Hi, Any chance we could get this for the 3.20 series? Cheers, Liz
This patch has been pushed to 3.20.x, will be in 3.20.10.
Brilliant, thank you! Liz