Expand the existing Purchase Suggestion to cater for titles already found in the library catalogue. Currently, it is impossible to link a suggestion to a matching catalogue record. Some catalogue records may no longer have items/holdings attached (as they could have been deleted earlier). Also it will be nice that titles accepted for purchase, also appear in OPAC with a similar remark to items on order (i.e. 1 item accepted for purchase). This will prevent repeated suggestions of the same title from different users!
The BULAC (http://www.bulac.fr/) would like to sponsore this development. As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>.
Created attachment 95170 [details] [review] Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created.
Hi Jonathan, I found 2 issues. I have this software error : "Tag "" is not a valid tag. at /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a suggestion using the empty form (opac & staff client) and saving a suggestion modification on staff client (no problem using the checkbox and drop-down menu). For suggestions made from an existing notice, suggestion status is not update after the adding to a basket (no problem for suggestions made from the empty form, and for the "Available" status after the receipt). Except these point, everything seems very clear to me and respond to our needs, so thanks a lot ! Icon on opac is ok for me.
Created attachment 95173 [details] [review] Bug 14963: Set status=ORDERED for suggestions created from existing record
(In reply to Séverine Queune from comment #3) > Hi Jonathan, > > I found 2 issues. > > I have this software error : "Tag "" is not a valid tag. at > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > suggestion using the empty form (opac & staff client) and saving a > suggestion modification on staff client (no problem using the checkbox and > drop-down menu). I do not understand that one. There are 2 bugs opened with this error but no idea where the error comes from. Can you detail a bit more? Reading the code it seems related to the item type. (for the record) 685 my ($it_tag, $it_subfield) = GetMarcFromKohaField('biblioitems.itemtype', ''); 686 if ($record->field( $it_tag )) { 687 $record->field( $it_tag )->add_subfields( $it_subfield => $suggestion->{itemtype} ); 688 } 689 else { 690 $record->append_fields( 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => $suggestion->{itemtype}) 692 ); 693 } > For suggestions made from an existing notice, suggestion status is not > update after the adding to a basket (no problem for suggestions made from > the empty form, and for the "Available" status after the receipt). Fixed! > Except these point, everything seems very clear to me and respond to our > needs, so thanks a lot ! > Icon on opac is ok for me. Thanks!
(In reply to Jonathan Druart from comment #5) > (In reply to Séverine Queune from comment #3) > > Hi Jonathan, > > > > I found 2 issues. > > > > I have this software error : "Tag "" is not a valid tag. at > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > suggestion using the empty form (opac & staff client) and saving a > > suggestion modification on staff client (no problem using the checkbox and > > drop-down menu). > > I do not understand that one. There are 2 bugs opened with this error but no > idea where the error comes from. Can you detail a bit more? > Reading the code it seems related to the item type. > > (for the record) > 685 my ($it_tag, $it_subfield) = > GetMarcFromKohaField('biblioitems.itemtype', ''); > 686 if ($record->field( $it_tag )) { > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > $suggestion->{itemtype} ); > 688 } > 689 else { > 690 $record->append_fields( > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > $suggestion->{itemtype}) > 692 ); > 693 } Oh... Weird... In my instance, there is no field mapped to biblioitems.itemtype, but if I add one, I can save the suggestion correctly. Is it the expected / future behaviour ? This a problem we don't have with 18.05.00 so we'll have to be be aware about adding a mapping for biblioitems.itemtype if so. My second try was an on different computer with a different resolution screen, I noticed a tiny display issu with the new link in OPAC (see attachement). Sorry I missed that on first test.
Created attachment 95174 [details] Tiny gap before the new "Suggestion" link
Created attachment 95175 [details] [review] Bug 14963: Fix ergonomic issue on small screen
(In reply to Séverine Queune from comment #6) > (In reply to Jonathan Druart from comment #5) > > (In reply to Séverine Queune from comment #3) > > > Hi Jonathan, > > > > > > I found 2 issues. > > > > > > I have this software error : "Tag "" is not a valid tag. at > > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > > suggestion using the empty form (opac & staff client) and saving a > > > suggestion modification on staff client (no problem using the checkbox and > > > drop-down menu). > > > > I do not understand that one. There are 2 bugs opened with this error but no > > idea where the error comes from. Can you detail a bit more? > > Reading the code it seems related to the item type. > > > > (for the record) > > 685 my ($it_tag, $it_subfield) = > > GetMarcFromKohaField('biblioitems.itemtype', ''); > > 686 if ($record->field( $it_tag )) { > > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > > $suggestion->{itemtype} ); > > 688 } > > 689 else { > > 690 $record->append_fields( > > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > > $suggestion->{itemtype}) > > 692 ); > > 693 } > > Oh... Weird... In my instance, there is no field mapped to > biblioitems.itemtype, but if I add one, I can save the suggestion correctly. > Is it the expected / future behaviour ? > This a problem we don't have with 18.05.00 so we'll have to be be aware > about adding a mapping for biblioitems.itemtype if so. I am not sure, but the code that is exploding comes from bug 14973 (so not pushed yet). Do you know why you do not have this mapping? Discussion should continue on bug 14973 if needed. > My second try was an on different computer with a different resolution > screen, I noticed a tiny display issu with the new link in OPAC (see > attachement). Sorry I missed that on first test. Fixed. You will need to regenerate the CSS file to see the changes: yarn build --view opac
Created attachment 95195 [details] [review] Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 95196 [details] [review] Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 95197 [details] [review] Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 95198 [details] [review] Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 95200 [details] [review] Bug 14973: Remove double declaration of suggestions_loop
Created attachment 95201 [details] [review] Bug 14973: Add missing filters in templates
Created attachment 95202 [details] [review] Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95203 [details] [review] Bug 14963: Set status=ORDERED for suggestions created from existing record Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95204 [details] [review] Bug 14963: Fix ergonomic issue on small screen Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
I'm sorry Jonathan, I missed everything with bug 14973 when I signed the present one... #shameonme...
(In reply to Séverine Queune from comment #19) > I'm sorry Jonathan, I missed everything with bug 14973 when I signed the > present one... > #shameonme... I will fix that :)
Created attachment 95205 [details] [review] Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95206 [details] [review] Bug 14963: Set status=ORDERED for suggestions created from existing record Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95207 [details] [review] Bug 14963: Fix ergonomic issue on small screen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 96322 [details] [review] Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 96323 [details] [review] Bug 14963: Set status=ORDERED for suggestions created from existing record Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 96324 [details] [review] Bug 14963: Fix ergonomic issue on small screen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
What do you think of using a little 'present' icon instead of the money (bill) icon? Also we could slightly rephrase it to make it shorter: Currently: New purchase suggestion for this title Suggestion: Suggest for purchase
Bug 24344
New feature. Not backported to 19.11.x
This fix is working after my 20.05, but I don't have any way to turn off/hide the "suggest for purchase" button if we don't want it. The other opac-detail-sidebar.inc buttons each have a class on the link element ("reserve" or "print-large") so I can hide them using CSS. "Suggest for purchase" has no class for CSS manipulation,. I don't think adding/changing system preferences is necessary, just adding a class to the link in Koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc (currently on line 37)
Hello Hannah, could you report this on a separate bug report?
Moved my comment to a new bug - bug 26094
I just tested this feature on 20.11.12 and when adding a suggestion from the detail page the biblionumber is not filled in. I think this is a bug, can you confirm?
(In reply to Katrin Fischer from comment #34) > I just tested this feature on 20.11.12 and when adding a suggestion from the > detail page the biblionumber is not filled in. I think this is a bug, can > you confirm? Confirmed, on master as well. Certainly caused by bug 28941.
(In reply to Jonathan Druart from comment #35) > (In reply to Katrin Fischer from comment #34) > > I just tested this feature on 20.11.12 and when adding a suggestion from the > > detail page the biblionumber is not filled in. I think this is a bug, can > > you confirm? > > Confirmed, on master as well. Certainly caused by bug 28941. Opened bug 29696.