Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber)
Created attachment 128536 [details] [review] Bug 29696: Add tests
Created attachment 128537 [details] [review] Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved
Thx Joubu!
Created attachment 128701 [details] [review] Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 128702 [details] [review] Bug 29696: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 128703 [details] [review] Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx a lot. I had some trouble running the selenium tests (with and without patch), so maybe QA can take care of that? :)
Created attachment 128818 [details] [review] Bug 29696: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 128819 [details] [review] Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Pushed to 21.05.x for 21.05.08
Backported: Pushed to 20.11.x branch for 20.11.15
Do I need to backport this to 19.11.x? I probably won't unless there is a need for it
Not backported to 19.11.x for 19.11.26. Please request it if you need it.