Displaying the item's homebranch for item in "Description of charges" would be useful.
I've submitted a pull request for this enhancement. https://github.com/Koha-Community/Koha/pull/10
Hi Vassilis, thx for your contribution! Can you please attach a patch file to this bug? The Koha community is not using github pull requests in its development workflow. Some additional information can be found on the wiki: http://wiki.koha-community.org/wiki/Development_workflow http://wiki.koha-community.org/wiki/SubmitingAPatch
Created attachment 44630 [details] [review] add homebranch of borrowed items
Thx Vassilis! Once the patch file is attached, you can switch the bug status to "Needs Signoff". This way it shows up on the queues for things to be tested. One tiny thing about your patch: + <th>Item Homebranch</th> We only have the first term in capitals, also please check the term we use in the normal item view or in the checkouts list for comparison.
Created attachment 44644 [details] [review] add homebranch of borrowed items
Thanks Kartin. I've changed table heading.
Created attachment 44671 [details] [review] Add homebranch of borrowed items to patron accounts tab http://bugs.koha-community.org/show_bug.cgi?id=15136 Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Hi Vassilis, I signed off, works as expected. I added a test plan to the commit message, you should always include one with the patch submission to make testing easier (and so you can be sure that you and the tester agree on what the results should be :-) ) -Nick
(In reply to Nick Clemens from comment #8) > Hi Vassilis, > > I signed off, works as expected. I added a test plan to the commit message, > you should always include one with the patch submission to make testing > easier > (and so you can be sure that you and the tester agree on what the results > should be :-) ) > > -Nick Hi Nick, Thanks for the advice. It's my first contribution to Koha and I'm still learning the process.
Created attachment 44681 [details] [review] Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44682 [details] [review] Bug 15136: Use TT plugin to display the branch's name Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Why the patch doesn't apply? Please reason.
It means that it can't be applied with git - it needs to be rebased to fit with the current codebase.
OK. So I' ll rebase and submit the patch again. Thanks.
If it's a simple rebase, you can switch it back to "Passed QA" after. If it's more complicated, please switch to "Needs Sign-off" again.
Created attachment 71559 [details] [review] Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 71560 [details] [review] Bug 15136: Use TT plugin to display the branch's name Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nick: $data->{title} = $biblio->title; + $data->{homebranch} = $biblio->{homebranch}; This reads wrong. Moreover GetMemberAccountRecords will be removed by bug 12001.
Created attachment 76112 [details] [review] Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column
Created attachment 76308 [details] [review] Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works.
Created attachment 77174 [details] [review] Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work and congratulations on your first patch Vassilis! Pushged to master for 18.11
Enhancement, won't be backported to 18.05.x series.
After the new column with homebranch was added the button for "filter paid transactions" does not work. The code that should be adjusted is: table_account_fines.fnFilter(filteredValue, 4, true, false); it should now be table_account_fines.fnFilter(filteredValue, 5, true, false);
Will open new bug
Created attachment 79711 [details] [review] Bug 15136: (follow-up) Fix 'Filter paid transactions' button
New bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
Comment on attachment 79711 [details] [review] Bug 15136: (follow-up) Fix 'Filter paid transactions' button Moved to bug 21462