Bug 21462 - "Filter paid transactions" stopped working after html-table was changed
Summary: "Filter paid transactions" stopped working after html-table was changed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Johan Larsson
QA Contact: Testopia
URL:
Keywords:
Depends on: 15136
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-01 12:49 UTC by Johan Larsson
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
wrong column was selected for filtering the table. This was caused by changing the hmtl-structure of the table (1.24 KB, patch)
2018-10-01 13:01 UTC, Johan Larsson 		Details | Diff | Splinter Review
Bug 21462: (bug 15136 follow-up) Shift column numbering (1.29 KB, patch)
2018-10-01 16:24 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Larsson 2018-10-01 12:49:22 UTC 
Related to 15136
Comment 1 Johan Larsson 2018-10-01 13:01:40 UTC 
Created attachment 79713 [details] [review]
wrong column was selected for filtering the table. This was caused by changing the hmtl-structure of the table
Comment 2 Jonathan Druart 2018-10-01 16:24:12 UTC 
Hi Johan, thanks for your patch.
Do not forget to switch the bug report's status to Needs Signoff to tell the community the patch is ready for testing.
You should also read this wiki page to format the commit message following our guide lines: https://wiki.koha-community.org/wiki/Commit_messages
Comment 3 Jonathan Druart 2018-10-01 16:24:35 UTC 
Created attachment 79744 [details] [review]
Bug 21462: (bug 15136 follow-up) Shift column numbering

Wrong column was selected for filtering the table.
This was caused by changing the hmtl-structure of the table

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2018-10-01 16:24:55 UTC 
Trivial patch, skipping QA.
Comment 5 Nick Clemens (kidclamp) 2018-10-02 00:15:15 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize (ashimema) 2018-10-08 08:06:48 UTC 
Caused by enhancement not in 18.05.x series.