The nonpublic note would be useful in the overdues report as well.
Another library is asking for this - almost missed I had already filed a report.
Still valid!
Created attachment 77730 [details] [review] Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows
Created attachment 77731 [details] [review] Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows - Download list of overdues - Verify the new column displays
Created attachment 78871 [details] screenshot of results The report exports correctly, but the columns do not line up correctly in Koha's display. (http://staff-spicypeanut.sb1.sandboxes.bywatersolutions.com/cgi-bin/koha/circ/overdue.pl) See attached screenshot for example.
Also, this shows up in the header- <<<<<<< HEAD ======= >>>>>>> Bug 15139: Add non-public item notes to overdue report
Created attachment 78922 [details] [review] Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows - Download list of overdues - Verify the new column displays
Rebased and back to sign-off - thx for testing Spencer! It looks like the new sandboxes do not clearly report when a patch doesn't apply. In a case like this, you don't need to test further when there are errors in the git log. It would be nice if that would be clearer for the sandbox user.
Created attachment 79034 [details] [review] Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows - Download list of overdues - Verify the new column displays Signed-off-by: Spencer <ssmith3@mckinneytexas.org>
Who do I bug about failed marking as signed-off for the ByWater Sandboxes?
Hm, Kyle? ;)
And thank you, Spencer!
- Library column was always empty, now library displays => Moved to its own bug report, see bug 21463
Created attachment 79784 [details] [review] Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows - Download list of overdues - Verify the new column displays Signed-off-by: Spencer <ssmith3@mckinneytexas.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: remove the branchcode line, added on its own bug report, see bug 21463
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.