The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl )
*** Bug 7142 has been marked as a duplicate of this bug. ***
Created attachment 38492 [details] [review] Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items
Created attachment 38503 [details] [review] [Signed-off] Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
QA comments: 1/ The items.itemnotes does not appear in the return table (already before this patch). I think it's because of circ/returns.pl: 577 $ri{itemnote} = $biblio->{'itemnotes'}; should be 577 $ri{itemnote} = $item->{'itemnotes'}; 2/ The non public notes does not appear in the relatives issues table. 3/ Do you know what is the span class "circ-hlt"? Marked as Failed QA for 2, but it would be great to see 1 fixed too.
Ping Kyle!
Created attachment 45283 [details] [review] Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 45284 [details] [review] Bug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts
(In reply to Jonathan Druart from comment #4) > QA comments: > > 1/ The items.itemnotes does not appear in the return table (already before > this patch). I think it's because of circ/returns.pl: > 577 $ri{itemnote} = $biblio->{'itemnotes'}; > should be > 577 $ri{itemnote} = $item->{'itemnotes'}; Can't reproduce, is it fixed in master? > > 2/ The non public notes does not appear in the relatives issues table. > Fixed! > 3/ Do you know what is the span class "circ-hlt"? It makes text bold and red. Not sure why we only do that for notes on the day its checked out but that's how it is. > > Marked as Failed QA for 2, but it would be great to see 1 fixed too.
Created attachment 45313 [details] [review] Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45314 [details] [review] Bug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Kyle M Hall from comment #8) > (In reply to Jonathan Druart from comment #4) > > QA comments: > > > > 1/ The items.itemnotes does not appear in the return table (already before > > this patch). I think it's because of circ/returns.pl: > > 577 $ri{itemnote} = $biblio->{'itemnotes'}; > > should be > > 577 $ri{itemnote} = $item->{'itemnotes'}; > > Can't reproduce, is it fixed in master? Hum, it works actually. Sorry about that. Not sure what I tested.
Patches pushed to master. Thanks self! ; )
Patches pushed to 3.22.x, will be in 3.22.1
This patch has been pushed to 3.20.x, will be in 3.20.7.
Hm, why not also show it on the details page directly? Just wondering, before filing another bug :)
(In reply to Katrin Fischer from comment #15) > Hm, why not also show it on the details page directly? Just wondering, > before filing another bug :) Fixed by bug 16130!