Created attachment 45328 [details] [review] Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice
Created attachment 45329 [details] [review] Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice
*** Bug 15281 has been marked as a duplicate of this bug. ***
Does not work for me. Message I received was The following items have been checked out: [% biblio.title %] Thank you for visiting [% branch.branchname %]. (In reply to Kyle M Hall from comment #1) > 1) Ensure dependancies are applied Are there dependencies not listed here?
Created attachment 47399 [details] [review] Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Blocked by bug 14757.
Created attachment 57173 [details] [review] [SIGNED-OFF] Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Ok so, beginning of a release cycle, let's take decisions! What is the plan of attack for these notices? I think we need to know if 1. everybody agrees with the TT syntax for notices and 2. we have dedicated time in a release cycle to move all of the existing notices to TT syntax. I don't think it's a good idea not to move all of the notices at the same time (ie. during the same release cycle).
(In reply to Jonathan Druart from comment #8) > Ok so, beginning of a release cycle, let's take decisions! > > What is the plan of attack for these notices? > I think we need to know if 1. everybody agrees with the TT syntax for > notices and 2. we have dedicated time in a release cycle to move all of the > existing notices to TT syntax. > I don't think it's a good idea not to move all of the notices at the same > time (ie. during the same release cycle). I totally agree with that. I think first we need to start a mailing list topic for this which should end with a simple vote of whether to continue to use the existing syntax by default or to switch to TT by default and eventually deprecate the existing syntax. What do you think?
(In reply to Kyle M Hall from comment #9) > (In reply to Jonathan Druart from comment #8) > > Ok so, beginning of a release cycle, let's take decisions! > > > > What is the plan of attack for these notices? > > I think we need to know if 1. everybody agrees with the TT syntax for > > notices and 2. we have dedicated time in a release cycle to move all of the > > existing notices to TT syntax. > > I don't think it's a good idea not to move all of the notices at the same > > time (ie. during the same release cycle). > > I totally agree with that. I think first we need to start a mailing list > topic for this which should end with a simple vote of whether to continue to > use the existing syntax by default or to switch to TT by default and > eventually deprecate the existing syntax. What do you think? We already had one :) http://lists.koha-community.org/pipermail/koha-devel/2016-February/042316.html
Created attachment 59614 [details] [review] Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
The fact that we should replace <<branches.field>> by [% branch.field %] is somewhat confusing ;)
I think that this patch should not be pushed before bug 17964.
(In reply to Jonathan Druart from comment #13) > I think that this patch should not be pushed before bug 17964. There is no direct connection? These patches do a simple change to the default notice that works and only depends on biblio and branch, not issues.
(In reply to Marcel de Rooy from comment #14) > (In reply to Jonathan Druart from comment #13) > > I think that this patch should not be pushed before bug 17964. > > There is no direct connection? These patches do a simple change to the > default notice that works and only depends on biblio and branch, not issues. They prove that CHECKIN and CHECKOUT work and will still work if a change is done in template processing.
Waiting a bit before marking the TT syntax as default.
Created attachment 79864 [details] [review] Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 79897 [details] [review] Bug 15280: Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.