Bug 15282 - Switch default CHECKIN notice to Template Toolkit
Summary: Switch default CHECKIN notice to Template Toolkit
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 15280 17961
Blocks: 15278 15283
  Show dependency treegraph
 
Reported: 2015-12-02 15:49 UTC by Kyle M Hall
Modified: 2019-10-14 19:56 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15282 - Switch default CHECKIN notice to Template Toolkit (31.03 KB, patch)
2015-12-02 15:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15282 - Switch default CHECKIN notice to Template Toolkit (31.05 KB, patch)
2016-01-28 18:33 UTC, Mirko Tietgen
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15282 - Switch default CHECKIN notice to Template Toolkit (31.09 KB, patch)
2016-11-04 10:14 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15282 - Switch default CHECKIN notice to Template Toolkit (31.18 KB, patch)
2017-01-27 10:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 15282 - Switch default CHECKIN notice to Template Toolkit (27.22 KB, patch)
2018-10-03 11:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15282: Switch default CHECKIN notice to Template Toolkit (27.27 KB, patch)
2018-10-03 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-12-02 15:49:57 UTC

    
Comment 1 Kyle M Hall 2015-12-02 15:52:05 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2016-01-28 18:33:04 UTC
Created attachment 47400 [details] [review]
Bug 15282 - Switch default CHECKIN notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKIN notice to match the following:

The following items have been checked in:
----
[% biblio.title %]
----
Thank you.

3) Generate a CHECKIN notice for a patron
4) Note there is no change to the generated notice

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 3 Jonathan Druart 2016-02-09 08:57:52 UTC
Blocked by bug 14757.
Comment 4 Josef Moravec 2016-11-04 10:14:21 UTC
Created attachment 57174 [details] [review]
[SIGNED-OFF] Bug 15282 - Switch default CHECKIN notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKIN notice to match the following:

The following items have been checked in:
----
[% biblio.title %]
----
Thank you.

3) Generate a CHECKIN notice for a patron
4) Note there is no change to the generated notice

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Marcel de Rooy 2017-01-27 10:44:50 UTC
Created attachment 59615 [details] [review]
Bug 15282 - Switch default CHECKIN notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKIN notice to match the following:

The following items have been checked in:
----
[% biblio.title %]
----
Thank you.

3) Generate a CHECKIN notice for a patron
4) Note there is no change to the generated notice

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Jonathan Druart 2017-01-27 10:58:51 UTC
I think that this patch should not be pushed before bug 17964.
Comment 7 Jonathan Druart 2017-06-05 17:12:01 UTC
Waiting a bit before marking the TT syntax as default.
Comment 8 Katrin Fischer 2018-03-30 09:39:45 UTC
Dependency doesn't apply. Moving to PDA.
Comment 9 Kyle M Hall 2018-10-03 11:08:14 UTC
Created attachment 79866 [details] [review]
Bug 15282 - Switch default CHECKIN notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKIN notice to match the following:

The following items have been checked in:
----
[% biblio.title %]
----
Thank you.

3) Generate a CHECKIN notice for a patron
4) Note there is no change to the generated notice

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Jonathan Druart 2018-10-03 14:54:15 UTC
Created attachment 79898 [details] [review]
Bug 15282: Switch default CHECKIN notice to Template Toolkit

Test Plan:
1) Ensure dependancies are applied
2) Apply this patch
3) Update your CHECKIN notice to match the following:

The following items have been checked in:
----
[% biblio.title %]
----
Thank you.

3) Generate a CHECKIN notice for a patron
4) Note there is no change to the generated notice

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Nick Clemens 2018-10-19 17:30:30 UTC
Awesome work all!

Pushed to master for 18.11
Comment 12 Martin Renvoize 2018-11-06 10:17:24 UTC
Enhancement will not be backported to 18.05.x series.