Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
Summary: XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nicholas van Oudtshoorn
QA Contact: Marcel de Rooy
URL:
Keywords:
: 6849 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-12-22 03:45 UTC by Nicholas van Oudtshoorn
Modified: 2017-06-14 22:10 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Adjust modulePath in zebra config to also work on 64 bit non-debian boxes (3.65 KB, patch)
2015-12-22 03:49 UTC, Nicholas van Oudtshoorn
Details | Diff | Splinter Review
Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora. (3.81 KB, patch)
2015-12-23 19:08 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora. (4.08 KB, patch)
2015-12-28 08:30 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas van Oudtshoorn 2015-12-22 03:45:08 UTC
This patches the zebra configuration so that their modulePath will work on Fedora (CentOS) based systems out of the box. Similar to bug 14106, this simply adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora.
Comment 1 Nicholas van Oudtshoorn 2015-12-22 03:49:24 UTC Comment hidden (obsolete)
Comment 2 David Cook 2015-12-23 01:21:51 UTC
Nice one, Nicholas. This is also an issue on openSUSE. 

We just made a symlink between /usr/lib/idzebra-2.0 and /usr/lib64/idzebra-2.0 to get around this issue, but it would be good to have this properly fixed via this patch.

I haven't tested this, as I don't have time at the moment, but it looks good at a glance. Very helpful patch.
Comment 3 Nicholas van Oudtshoorn 2015-12-23 02:55:35 UTC
Thanks David - let's hope someone can sign off on it soon! :-)
Comment 4 David Cook 2015-12-23 05:51:55 UTC
(In reply to Nicholas van Oudtshoorn from comment #3)
> Thanks David - let's hope someone can sign off on it soon! :-)

I'll put it on my "to do" list for the New Year, but hopefully someone gets to it before I try to find the time!
Comment 5 Chris Cormack 2015-12-23 19:08:31 UTC Comment hidden (obsolete)
Comment 6 Nicholas van Oudtshoorn 2015-12-24 06:28:46 UTC
*** Bug 6849 has been marked as a duplicate of this bug. ***
Comment 7 Jonathan Druart 2015-12-26 12:20:24 UTC
Waiting for another signoff from someone using a non debian-based system.
Comment 8 Marcel de Rooy 2015-12-27 16:20:45 UTC
(In reply to Jonathan Druart from comment #7)
> Waiting for another signoff from someone using a non debian-based system.

This just adds one extra path to modulepath. It should not break anything (as confirmed by one signoff at least).
I would favor passing QA if the non-debian user does not show up in reasonable time. (Unfortunately I gave up Fedora recently..)
Comment 9 Bob Ewart 2015-12-27 20:07:05 UTC
(In reply to Jonathan Druart from comment #7)
> Waiting for another signoff from someone using a non debian-based system.

It works on openSUSE Leap 42.1

Signed-off-by: Bob Ewart bob-ewart@bobsown.net
Comment 10 Bob Ewart 2015-12-27 20:10:22 UTC
(In reply to Bob Ewart from comment #9)
> (In reply to Jonathan Druart from comment #7)
> > Waiting for another signoff from someone using a non debian-based system.
> 
> It works on openSUSE Leap 42.1
> 
> Signed-off-by: Bob Ewart bob-ewart@bobsown.net

make that bob-ewart@bobsown.com
Comment 11 Katrin Fischer 2015-12-27 20:38:23 UTC
Thx Bob!
Comment 12 Marcel de Rooy 2015-12-28 08:30:12 UTC
Created attachment 45993 [details] [review]
Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux Adjusts the modulePath to search in the well-known location for 64 bit systems. Required for at least Fedora.

Test plan:
Without this patch, doing a zebra reindex on a fedora-based install will cause errors like this:
15:10:47-01/05 zebraidx(16108) [warn] No such record type: dom./etc/koha/zebradb/biblios/etc/dom-config.xml
With this patch, reindexing should just work.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
I have tested this doesn't break on debian/ubuntu systems, someone with a non
debian system will need to test it on that

Signed-off-by: Bob Ewart bob-ewart@bobsown.com
It works on openSUSE Leap 42.1

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Just noting that the debian zebra files already contain much more paths here.
Comment 13 Kyle M Hall 2015-12-30 14:36:51 UTC
Pushed to master, thanks Nicholas!
Comment 14 Julian Maurice 2015-12-31 09:53:48 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 15 Frédéric Demians 2015-12-31 18:31:48 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.