Bug 15431 - svc/checkouts dies due to undefined variable (13024 merge problem)
Summary: svc/checkouts dies due to undefined variable (13024 merge problem)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.20
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 13024
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-28 13:58 UTC by Tomás Cohen Arazi
Modified: 2019-06-27 09:24 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This bug appears only in 3.20.7 version and is very visible and disturbing. It has been discussed on Koha mailing list: after a package upgrade, the check-out screen doesn't display anymore the checkout items table.
Version(s) released in:


Attachments
Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem) (1.47 KB, patch)
2015-12-28 14:02 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem) (1.61 KB, patch)
2015-12-28 20:38 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem) (1.68 KB, patch)
2015-12-28 20:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2015-12-28 13:58:56 UTC
When bug 13024 was merged into 3.20.x, a bug was introduced by replacing the old way to fetch itemtype descriptions with the newer (3.22+).

To reproduce:
- Perform a checkout on a patron
- Check so all checkouts are shown immediately
=> FAIL: It keeps loading forever. The logs show the svc/checkouts script died
Comment 1 Tomás Cohen Arazi 2015-12-28 14:02:55 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2015-12-28 20:38:31 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-12-28 20:55:40 UTC
Created attachment 46013 [details] [review]
[PASSED QA] Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem)

When bug 13024 was merged into 3.20.x, a bug was introduced by replacing the
old way to fetch itemtype descriptions with the newer (3.22+).

To test:
- Perform a checkout on a patron
- Check so all checkouts are shown immediately
=> FAIL: It keeps loading forever. The logs show the svc/checkouts script died
- Apply the patch
- Reload page
=> SUCCESS: It loads the circ information correctly
- Sign off :-D

Regards

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Frédéric Demians 2015-12-29 09:32:50 UTC
Pushed to 3.20.x
Comment 5 Katrin Fischer 2016-01-15 07:10:25 UTC
Hi Frederic, it looks like the text of the new release notes field might been cut off?
Comment 6 Frédéric Demians 2016-01-15 10:39:02 UTC
> Hi Frederic, it looks like the text of the new release notes field might
> been cut off?

Yes. Chris is investigating...
Comment 7 Sophie MEYNIEUX 2016-02-01 15:34:22 UTC
It seems to have the same pb on Hold(s) tab
Comment 8 Frédéric Demians 2016-02-01 16:03:09 UTC
(In reply to Sophie MEYNIEUX from comment #7)
> It seems to have the same pb on Hold(s) tab

Which version? Is it solved on 3.20.8?
Comment 9 Sophie MEYNIEUX 2016-02-02 09:24:11 UTC
In 3.20.7
Comment 10 Frédéric Demians 2016-02-02 10:18:56 UTC
(In reply to Sophie MEYNIEUX from comment #9)
> In 3.20.7

Try upgrading to 3.20.8, and confirm it solves the issue.