Bug 15442 - Checkouts table will not display due to javascript error
Summary: Checkouts table will not display due to javascript error
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low blocker
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on: 15289
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-30 14:26 UTC by Kyle M Hall (khall)
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15442 - Checkouts table will not display due to javascript error (1.31 KB, patch)
2015-12-30 14:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 15442 - Checkouts table will not display due to javascript error (1.38 KB, patch)
2015-12-30 15:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set (2.77 KB, patch)
2016-01-05 15:07 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2015-12-30 14:26:13 UTC
Uncaught ReferenceError: AllowCirculate is not defined
Comment 1 Kyle M Hall (khall) 2015-12-30 14:27:33 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-12-30 15:04:09 UTC
Created attachment 46086 [details] [review]
Bug 15442 - Checkouts table will not display due to javascript error

Uncaught ReferenceError: AllowCirculate is not defined

Test Plan:
1) Go to circulation.pl for a patron, note the checkouts table
   does not load
2) Apply this patch
3) Reload the page, checkouts table should show

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2015-12-30 15:04:28 UTC
Trivial, skipping QA.
Comment 4 Kyle M Hall (khall) 2015-12-30 15:08:37 UTC
Pushed to master!
Comment 5 Julian Maurice 2015-12-31 08:48:17 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 6 Frédéric Demians 2015-12-31 18:28:23 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.
Comment 7 Jonathan Druart 2016-01-04 09:03:32 UTC
(In reply to Frédéric Demians from comment #6)
> This patch has been pushed to 3.20.x, will be in 3.20.8.

This patch is a bug fix for bug 15289, which is not in 3.20.x.
It was not needed for this branch but won't cause any regression.
Comment 8 Marc Véron 2016-01-05 15:07:21 UTC Comment hidden (obsolete)
Comment 9 Marc Véron 2016-01-05 15:08:47 UTC
Comment on attachment 46264 [details] [review]
Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set

Mistaked with the bug number, sorry for the noise...