Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP
Summary: Re-code RESERVESLIP as HOLD_SLIP
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on: 8085
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-30 15:00 UTC by Kyle M Hall (khall)
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP (9.89 KB, patch)
2015-12-30 15:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP (8.61 KB, patch)
2015-12-30 15:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP (8.92 KB, patch)
2015-12-31 14:39 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP (8.96 KB, patch)
2016-01-04 11:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2015-12-30 15:00:40 UTC
It's a bit confusing to have RESERVESLIP named "Hold Slip", we should finish the job and recode the slip.
Comment 1 Kyle M Hall (khall) 2015-12-30 15:04:41 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2015-12-30 15:06:30 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2015-12-31 14:39:10 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-04 11:50:56 UTC
Created attachment 46226 [details] [review]
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP

It's a bit confusing to have RESERVESLIP named "Hold Slip", we should
finish the job and recode the slip.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Try printing a hold slip, you should note no difference
   from pre-patch behavior

Followed test plan. The slip is triggered if you want to check out
an item that is reserved / on hold for another patron. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Kyle M Hall (khall) 2016-01-04 12:53:05 UTC
Pushed to master!