Bug 8085 - Rename 'Reserve slip' to 'Hold slip'
Summary: Rename 'Reserve slip' to 'Hold slip'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 15443
  Show dependency treegraph
 
Reported: 2012-05-14 15:01 UTC by Nicole C. Engard
Modified: 2017-06-14 22:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9184: Rename 'Reserve slip' to 'Hold slip' (5.57 KB, patch)
2015-11-22 00:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9184: Rename 'Reserve slip' to 'Hold slip' (5.80 KB, patch)
2015-11-24 14:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations (1.20 KB, patch)
2015-12-03 13:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations (1.41 KB, patch)
2015-12-08 13:17 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 8085: Rename 'Reserve slip' to 'Hold slip' (5.77 KB, patch)
2015-12-08 16:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations (1.48 KB, patch)
2015-12-08 16:03 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-05-14 15:01:23 UTC
We use the word Hold(s) throughout Koha, but the Notices & Slips tool lists the Holds Slip as Reserve Slip.
Comment 1 Owen Leonard 2012-05-17 12:30:42 UTC
The text comes from the database (letters.name), so this isn't a template bug. We'll have to revise the default data and update existing installations to correct the name.
Comment 2 Nicole C. Engard 2012-05-17 12:38:23 UTC
I'm not talking about RESERVESLIP - the code - I'm talking about the 'descriptive text' which also says Reserve.

I know we can't change the DB easily.
Comment 3 Owen Leonard 2012-05-17 12:47:15 UTC
letters.name (the identifier in the Notices interface) = "Reserve Slip" and letters.title (the message subject) = "Reserve Slip." So two instances in the database need to be modified.
Comment 4 Katrin Fischer 2015-06-06 22:41:53 UTC
Still valid
Comment 5 Katrin Fischer 2015-11-22 00:40:20 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2015-11-24 14:02:54 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2015-12-02 09:54:04 UTC
Don't you think we could update existing installations too?
Comment 8 Katrin Fischer 2015-12-02 22:16:40 UTC
I thought about it, but then opted for "no surprise". If you are used to edit the Reserve Slip it might be irritating to find it renamed... but I can certainly write a follow-up if you think. I'd check for "Reserve slip" in the description, because of possible translations then.
Comment 9 Katrin Fischer 2015-12-03 13:04:49 UTC Comment hidden (obsolete)
Comment 10 Katrin Fischer 2015-12-03 13:08:47 UTC
I have added another patch to update existing installations - please test and comment if you think if this change is useful.
Comment 11 Frédéric Demians 2015-12-08 13:17:03 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2015-12-08 16:02:58 UTC
Created attachment 45503 [details] [review]
Bug 8085: Rename 'Reserve slip' to 'Hold slip'

This patch changes all occurrences of 'Reserve slip'
to 'Hold slip' in the sample notices files and
in one of the system preferences.

To test:
- Make sure the sample_notices.sql are correctly
  changed.
- Verify the description of the SlipCSS system
  preference has been changed correctly.

Checked the working in system preferences and re-loaded notices from the
updated English sample notices SQL. Changes look correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2015-12-08 16:03:05 UTC
Created attachment 45504 [details] [review]
Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations

Title and description are updated separately, in case that the
library has changed one of them when editing the slip.

To test:
- Verify that you have a letter named 'Reserve Slip' in your database
- Run the database update
- Verify the slip has been renamed correctly

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Job done on a Koha English version. It won't hurt other langages

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Kyle M Hall 2015-12-30 14:57:50 UTC
Pushed to master, thanks Katrin!