We use the word Hold(s) throughout Koha, but the Notices & Slips tool lists the Holds Slip as Reserve Slip.
The text comes from the database (letters.name), so this isn't a template bug. We'll have to revise the default data and update existing installations to correct the name.
I'm not talking about RESERVESLIP - the code - I'm talking about the 'descriptive text' which also says Reserve. I know we can't change the DB easily.
letters.name (the identifier in the Notices interface) = "Reserve Slip" and letters.title (the message subject) = "Reserve Slip." So two instances in the database need to be modified.
Still valid
Created attachment 45075 [details] [review] Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly.
Created attachment 45119 [details] [review] [SIGNED-OFF] Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. http://bugs.koha-community.org/show_bug.cgi?id=8085 Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Don't you think we could update existing installations too?
I thought about it, but then opted for "no surprise". If you are used to edit the Reserve Slip it might be irritating to find it renamed... but I can certainly write a follow-up if you think. I'd check for "Reserve slip" in the description, because of possible translations then.
Created attachment 45352 [details] [review] Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly
I have added another patch to update existing installations - please test and comment if you think if this change is useful.
Created attachment 45492 [details] [review] Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Job done on a Koha English version. It won't hurt other langages
Created attachment 45503 [details] [review] Bug 8085: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45504 [details] [review] Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Job done on a Koha English version. It won't hurt other langages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, thanks Katrin!
Created attachment 167631 [details] [review] Bug 8085: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>