Most of the changes from 'Item' to 'Patron' were fixed, but there is one case where it still says 'Item Count' and a case for a translatability fix.
Created attachment 46624 [details] [review] Bug 15573: String and translatability fix to Patron Card Creator To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)'
Created attachment 46638 [details] [review] [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Rewording Ok for translatability purpose
Comment on attachment 46638 [details] [review] [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator Review of attachment 46638 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ +179,4 @@ > > [% IF ( duplicate_message ) %] > <div class="dialog message"> > + <strong>Duplicates removed from batch number [% batch_id %]:</strong> [% duplicate_count %] patron(s) To avoid the string to be split, maybe could we put the entire string in the same tag?
Created attachment 46671 [details] [review] Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)'
Created attachment 46678 [details] [review] [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Rewording Ok for translatability purpose
Created attachment 46703 [details] [review] Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Rewording Ok for translatability purpose Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46704 [details] [review] Bug 15573 [QA Followup] - Tweak wording Based on JS4 of the coding guidelines, it seems improper embed the count in the middle of this string. I think this working may be more correct. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks!
From discussion on bug 15662, it appears that the original wording was better. The problem was not the wording bug the strong tag in the middle of the sentence.
Patch pushed to 3.22.x, will be in 3.22.4