Bug 15573 - String and translatability fix to Patron Card Creator
Summary: String and translatability fix to Patron Card Creator
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-13 23:00 UTC by Aleisha Amohia
Modified: 2017-06-14 22:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15573: String and translatability fix to Patron Card Creator (2.41 KB, patch)
2016-01-13 23:03 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator (2.52 KB, patch)
2016-01-14 04:53 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15573: String and translatability fix to Patron Card Creator (2.43 KB, patch)
2016-01-14 22:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator (2.55 KB, patch)
2016-01-15 01:30 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15573: String and translatability fix to Patron Card Creator (2.59 KB, patch)
2016-01-15 15:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15573 [QA Followup] - Tweak wording (1.27 KB, patch)
2016-01-15 15:51 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-01-13 23:00:11 UTC
Most of the changes from 'Item' to 'Patron' were fixed, but there is one case where it still says 'Item Count' and a case for a translatability fix.
Comment 1 Aleisha Amohia 2016-01-13 23:03:49 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-14 04:53:40 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-14 11:07:09 UTC
Comment on attachment 46638 [details] [review]
[SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator

Review of attachment 46638 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
@@ +179,4 @@
>  
>                  [% IF ( duplicate_message ) %]
>                      <div class="dialog message">
> +                        <strong>Duplicates removed from batch number [% batch_id %]:</strong> [% duplicate_count %] patron(s)

To avoid the string to be split, maybe could we put the entire string in the same tag?
Comment 4 Aleisha Amohia 2016-01-14 22:01:55 UTC Comment hidden (obsolete)
Comment 5 Héctor Eduardo Castro Avalos 2016-01-15 01:30:42 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2016-01-15 15:51:07 UTC
Created attachment 46703 [details] [review]
Bug 15573: String and translatability fix to Patron Card Creator

Fixing the split string

To test:

1) Go to Tools -> Patron Card Creator -> Manage -> Card batches
2) Confirm the table heading reads 'Patron Count'
3) Edit a batch
4) Click Remove duplicates
5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)'

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described. Rewording Ok for translatability purpose

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Kyle M Hall 2016-01-15 15:51:15 UTC
Created attachment 46704 [details] [review]
Bug 15573 [QA Followup] - Tweak wording

Based on JS4 of the coding guidelines, it seems improper embed the count
in the middle of this string. I think this working may be more correct.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Brendan Gallagher 2016-01-27 05:40:39 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 9 Jonathan Druart 2016-01-29 11:19:57 UTC
From discussion on bug 15662, it appears that the original wording was better.
The problem was not the wording bug the strong tag in the middle of the sentence.
Comment 10 Julian Maurice 2016-02-19 08:44:36 UTC
Patch pushed to 3.22.x, will be in 3.22.4