1) "Please select at least label to delete" - missing a word 2) <strong>[% duplicate_count %] duplicate item(s) found</strong> and removed from batch [% batch_id %] - split string
Created attachment 47292 [details] [review] Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold.
Created attachment 47306 [details] [review] [SIGNED-OFF]Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translatability purpose
The translatability issue came from the <strong> tag in the middle of the sentence. I think we can keep the previous sentence: [% duplicate_count %] duplicate item(s) found and removed from batch [% batch_id %]. Which looks better then the new one: Duplicate item(s) removed from batch number [% batch_id %]: [% duplicate_count %] Marc, any thoughts?
(In reply to Jonathan Druart from comment #3) > The translatability issue came from the <strong> tag in the middle of the > sentence. > I think we can keep the previous sentence: > [% duplicate_count %] duplicate item(s) found and removed from batch [% > batch_id %]. > > Which looks better then the new one: > Duplicate item(s) removed from batch number [% batch_id %]: [% > duplicate_count %] The original flows better than the proposed replacement imho.
I changed it so that it would be consistent with the duplicates message for Patron Card Creator, see Bug 15573 which has been pushed
I have let a note on bug 15573 comment 9
(In reply to Jonathan Druart from comment #6) > I have let a note on bug 15573 comment 9 This syntax style is based on coding guideline JS4. I think we should retain it for consistencies sake, or update the guidelines to reflect this new stance. Now that we have the format method for strings, this style of wording is no longer necessary.
(In reply to Kyle M Hall from comment #7) > (In reply to Jonathan Druart from comment #6) > > I have let a note on bug 15573 comment 9 > > This syntax style is based on coding guideline JS4. I think we should retain > it for consistencies sake, or update the guidelines to reflect this new > stance. Now that we have the format method for strings, this style of > wording is no longer necessary. Reading over JS4, it seems that even that may not cover all cases. It is conceivable that some languages may have syntax which wants the strings at the beginning rather than the end. That said, I have no problem with it going where ever; just a preference for the original.
> Reading over JS4, it seems that even that may not cover all cases. It is > conceivable that some languages may have syntax which wants the strings at > the beginning rather than the end. > > That said, I have no problem with it going where ever; just a preference for > the original. That sounds like a good argument for updating JS4. Using the format method allows the translator more control over where the numbers would appear. The only limitation would be that they must still be in the same order.
Created attachment 47681 [details] [review] Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translatability purpose Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the May 2016 release. Thanks!