Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup
Summary: Accessibility: Can't tab to add link in serials routing list add user popup
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: natasha
QA Contact: Testopia
URL: /cgi-bin/koha/serials/add_user_search.pl
Keywords: Academy
Depends on: 15602 15603 15604
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-19 17:25 UTC by Owen Leonard
Modified: 2017-01-10 19:36 UTC (History)
13 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup (1.60 KB, patch)
2016-01-20 02:37 UTC, natasha
Details | Diff | Splinter Review
Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup (1.77 KB, patch)
2016-01-25 15:07 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup (1.84 KB, patch)
2016-01-27 10:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15605: Remove the cursor:pointer style. (1.31 KB, patch)
2016-01-27 10:34 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-01-19 17:25:49 UTC
When adding users to a serial routing list, users can be selected from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Add" link. I assume this is because, like the problem in Bug 15602, the link has no href attribute.
Comment 1 natasha 2016-01-20 02:37:02 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-25 15:07:10 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-27 10:34:08 UTC
Created attachment 47329 [details] [review]
Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup

To Test -
1. Go to Serials and search for a title and then click on it.
2. Click routing list and then Add recipients.
3. Search for a patron.
4. Using the tab key try to navigate onto the Add link.
5. Notice it skips Add.
6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-01-27 10:34:13 UTC
Created attachment 47330 [details] [review]
Bug 15605: Remove the cursor:pointer style.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-02-23 23:07:49 UTC
Pushed to Master - Should be in the May 2016 Release - Thanks
Comment 6 Julian Maurice 2016-03-07 08:58:20 UTC
Patches pushed to stable, will be in 3.22.5
Comment 7 Frédéric Demians 2016-03-15 08:57:47 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.