Bug 15663 - Can't delete label from checkbox
Summary: Can't delete label from checkbox
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on: 14676
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-26 02:18 UTC by Aleisha Amohia
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15663: Fix 'remove selected items', add a 'delete batch' button (4.24 KB, patch)
2016-01-26 03:02 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15663: Fix 'remove selected items', add a 'delete batch' button (4.33 KB, patch)
2016-01-26 15:22 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15663: Fix 'remove selected items', add a 'delete batch' button (4.34 KB, patch)
2016-01-27 13:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-01-26 02:18:00 UTC
To reproduce:

1) Go to Tools -> Label creator -> New label batch
2) Add an item
3) Select the checkbox next to the item you just added and click 'Remove selected items'
4) A pop-up will say that you are yet to select an item - this is a bug. (I am aware of the missing word in the pop-up message, which has been fixed in Bug 15662). 

Setting severity to normal because it blocks the use of this button.
Comment 1 Aleisha Amohia 2016-01-26 03:02:41 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-26 15:18:08 UTC
Good cath Aleisha
Comment 3 Héctor Eduardo Castro Avalos 2016-01-26 15:22:47 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-01-26 15:46:42 UTC
Héctor, did you forget to set teh status tu signed-off?  :-)
Comment 5 Héctor Eduardo Castro Avalos 2016-01-26 15:54:21 UTC
(In reply to Marc Véron from comment #4)
> Héctor, did you forget to set teh status tu signed-off?  :-)

Thanks Marc. I've uncommented the line in git-bz, but maybe the program did not update.
Comment 6 Jonathan Druart 2016-01-27 13:08:26 UTC
Created attachment 47337 [details] [review]
Bug 15663: Fix 'remove selected items', add a 'delete batch' button

In this patch I have fixed the 'Remove selected items' button.
I have also added a 'Delete batch' button like there is in the Patron Card Creator.

To test:
1) Go to Tools -> Label creator -> New label batch
2) Add 2 items
3) Select the checkbox next to an item you just added and click 'Remove selected items'
4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662)
5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar
6) Select one item and click 'Remove selected items'
7) Confirm the item is deleted from the batch
8) Select the final item and click 'Remove selected items'
9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay'
10) Click 'Delete batch' then 'Okay'
11) Confirm you are redirected to the Labels page and the batch has been deleted.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2016-01-27 13:11:36 UTC
This patch update the label editor behaviors with the patroncard ones, but there are still lot of issues:
1/ You can select all the items and click on "remove selected" without any warning
2/ You can delete the last item clicking on the "Delete" button ("actions" column)

In these 2 cases, the batch_id parameter is passed but is wrong. If you add a new batch on the resulting screen, the batch_id of the deleted batch will be displayed, but a new one will be used.
Comment 8 Aleisha Amohia 2016-01-28 02:29:18 UTC
(In reply to Jonathan Druart from comment #7)
> This patch update the label editor behaviors with the patroncard ones, but
> there are still lot of issues:
> 1/ You can select all the items and click on "remove selected" without any
> warning
> 2/ You can delete the last item clicking on the "Delete" button ("actions"
> column)
> 
> In these 2 cases, the batch_id parameter is passed but is wrong. If you add
> a new batch on the resulting screen, the batch_id of the deleted batch will
> be displayed, but a new one will be used.

I think these are separate bugs and they definitely do need fixing
Comment 9 Marc Véron 2016-01-28 09:09:32 UTC
(In reply to Aleisha Amohia from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > This patch update the label editor behaviors with the patroncard ones, but
> > there are still lot of issues:
> > 1/ You can select all the items and click on "remove selected" without any
> > warning
> > 2/ You can delete the last item clicking on the "Delete" button ("actions"
> > column)
> > 
> > In these 2 cases, the batch_id parameter is passed but is wrong. If you add
> > a new batch on the resulting screen, the batch_id of the deleted batch will
> > be displayed, but a new one will be used.
> 
> I think these are separate bugs and they definitely do need fixing

See Bug 15663
Comment 10 Aleisha Amohia 2016-01-28 20:20:11 UTC
(In reply to Marc Véron from comment #9)
> 
> See Bug 15663

Do you mean Bug 14676?
Comment 11 Marc Véron 2016-01-28 21:28:59 UTC
(In reply to Aleisha Amohia from comment #10)
> (In reply to Marc Véron from comment #9)
> > 
> > See Bug 15663
> 
> Do you mean Bug 14676?

Sorry for my mistake, it is 
Bug 15689 - Label editor: Fix issues with wrong batch_id parameter
Comment 12 Brendan Gallagher 2016-02-23 22:54:17 UTC
Pushed to Master - Should be in the May 2016 Release - Thanks!
Comment 13 Julian Maurice 2016-03-07 09:00:17 UTC
Patch pushed to stable, will be in 3.22.5