Goal : Add ability to control if a staff user can create new patrons vs editing existing patrons Work to be done: 1) Add new borrowers sub-permission ‘modify’ 2) Add new borrowers sub-permission ‘create’ 3) Implement new permissions for patron editor/creator Looking for sponsors here: http://devs.bywatersolutions.com/projects/patron-edit-permission/
I think ideally we would add a third 'delete' permission, updated site link: http://devs.bywatersolutions.com/2016/11/30/Split-borrowers-permission-into-create-edit/
*** Bug 8535 has been marked as a duplicate of this bug. ***
I think in addition to giving a delete permission, we should also had a merge patron permission.
We just had our first accidental borrower deletion in almost 2 years, so I'm pleased to see this is already suggested! I'd like to see permissions broken down thus: create modify renew delete merge The funding link is broken. Is there still a call out for cosponsors?
I agree about delete and merge - but I am unsure about splitting create and modify. Say you create a new patron, but you discover you have typoed the email address or phone number after saving - you won't be able to fix it, if you don't have create and modify. I feel like they both should go together, but wonder if there is a use case where splitting makes sense?
One of our large public library customers is due to go live next month and are currently working out their staff permissions. This exact question has been asked - can they give the DELETE permission to some members of staff but not to others? This would be a very welcome enhancement as we really don't offer many patron permissions at all at present.
Created attachment 115091 [details] [review] Bug 15788: Add delete_borrowers permission
Created attachment 115092 [details] [review] Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu.
These patches simply add a 'delete_borrowers' sub-permissions and bind the option to delete borrowers to it. All other 'edit_borrowers' options should remain intact.
Anyone fancy testing this?
After applying the patch and the database update: - You can't expand any of the "Show details" to see the sub permissions for a patron. - There is an error in the web developer tools console: Uncaught ReferenceError: CAN_user_borrowers_delete_borrowers is not defined <anonymous> Ember jQuery 4 i fireWith ready J (A link is also provided to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Not_defined )
Created attachment 118865 [details] [review] Bug 15788: Add delete_borrowers permission
Created attachment 118866 [details] [review] Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu.
Thanks for testing David.. I found the issue, I'd neglected to add one of the files to the final commit! All sorted now, should be working this time around.. Doh!
Created attachment 118874 [details] [review] Bug 15788: Add delete_borrowers permission Signed-off-by: David Nind <david@davidnind.com>
Created attachment 118875 [details] [review] Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121887 [details] [review] Bug 15788: Add delete_borrowers permission Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121888 [details] [review] Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121889 [details] [review] Bug 15788: (QA follow-up) Simplify query in update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121890 [details] [review] Bug 15788: Make the API require the new permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Looks like we are missing renew and merge. It would have been good to split this bug report. Pushing as it anyway.
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported to 21.05.x