In contrast with item types, where you cannot delete an item type if existing records use it, Koha will let you delete a MARC framework even if there are existing records which use that framework code. I think the correct behavior is to prevent the user from proceeding with the deletion.
Created attachment 47931 [details] [review] Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly.
Created attachment 47933 [details] [review] Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 47973 [details] [review] Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Created attachment 48731 [details] [review] [3.22.x] Bug 15790 - Don't delete a MARC framework if existing records use that framework Patch for 3.22.x
Patch pushed to 3.22.x, will be in 3.22.5
This patch has been pushed to 3.20.x, will be in 3.20.10.