Created attachment 47863 [details] Screenshot showing the kind of dialog to be modified Some (non-JavaScript) dialogs in Koha show a pair of Yes/No buttons styled with "approve"/"deny" classes which use image files for the icon. These could instead be styled using Font Awesome icons.
Created attachment 47929 [details] [review] Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete
Created attachment 47930 [details] [review] [SIGNED-OFF]Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Icons changed
Created attachment 47932 [details] [review] Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Icons changed Signed-off-by: Marc Véron <veron@veron.ch>
Comment on attachment 47932 [details] [review] Bug 15785 - Use Font Awesome icons in confirmation dialogs Hector was faster :-) Obsoleting my sign-off patch.
Created attachment 47971 [details] [review] Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Icons changed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have fixed the conflicts with the revert of bug 13618
Created attachment 47983 [details] [review] Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hi someone attach a wrong bug number in this patch, please revert/obsolete the last patch attached
(In reply to Héctor Eduardo Castro Avalos from comment #8) > Hi someone attach a wrong bug number in this patch, please revert/obsolete > the last patch attached Done
Pushed to Master - Should be in the may 2016 release. Thanks