Bug 15804 - Use standard dialog style for confirmation of MARC subfield deletion
Summary: Use standard dialog style for confirmation of MARC subfield deletion
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/marc_subfields_st...
Keywords:
: 15805 (view as bug list)
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-11 16:16 UTC by Owen Leonard
Modified: 2017-06-14 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15804 - Use standard dialog style for confirmation of MARC subfield deletion (3.88 KB, patch)
2016-02-11 17:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15804 [Revised] Use standard dialog style for confirmation of MARC subfield deletion (3.96 KB, patch)
2016-02-17 14:03 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion (4.05 KB, patch)
2016-02-19 15:05 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion (4.05 KB, patch)
2016-02-19 15:06 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion (4.06 KB, patch)
2016-02-29 13:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion (4.06 KB, patch)
2016-02-29 13:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion (4.06 KB, patch)
2016-02-29 13:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
[3.22.x] Bug 15804: Use standard dialog style for confirmation of MARC subfield deletion (3.78 KB, patch)
2016-03-07 12:32 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-11 16:16:58 UTC
In Administration -> MARC bibliographic framework -> MARC structure -> Subfields, deleting a subfield triggers a confirmation which isn't styled like similar warnings in Koha. It should be wrapped in a <div class="dialog alert"></div>
Comment 1 Owen Leonard 2016-02-11 16:40:24 UTC
*** Bug 15805 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2016-02-11 17:34:02 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-02-12 14:27:14 UTC
Hi Owen

The patch fails

Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt


I applied 15785 on top and fails
Comment 4 Owen Leonard 2016-02-17 14:03:00 UTC Comment hidden (obsolete)
Comment 5 Héctor Eduardo Castro Avalos 2016-02-19 15:05:50 UTC Comment hidden (obsolete)
Comment 6 Héctor Eduardo Castro Avalos 2016-02-19 15:06:32 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-02-29 13:52:10 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-02-29 13:53:13 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2016-02-29 13:53:34 UTC
Created attachment 48455 [details] [review]
Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion

When deleting a MARC framework subfield, the confirmation message is not
styled. This patch modifies the template to style the confirmation
message like similar ones.

Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs

To test, apply the patch and go to Administration -> MARC framworks.

 - Click 'MARC structure' for a framework you can edit.
 - Click 'subfields' for a tag you can edit.
 - Click 'Delete' for a subfield you can delete. You should see a
   confirmation dialog styled like other "alert" type dialogs.
 - Test both canceling and confirming deletion to confirm that both
   function correctly.

Revised to fix conflicts with rollback of Bug 13618

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as expected. Revised according with bug revert 13618

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Brendan Gallagher 2016-03-02 03:21:37 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks
Comment 11 Julian Maurice 2016-03-07 12:32:07 UTC
Created attachment 48744 [details] [review]
[3.22.x] Bug 15804: Use standard dialog style for confirmation of MARC subfield deletion

Patch for 3.22.x
Comment 12 Julian Maurice 2016-03-07 12:32:57 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 13 Frédéric Demians 2016-03-15 09:01:51 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.