Bug 15858 - Use Font Awesome icons in dialog alert for addorder.tt
Summary: Use Font Awesome icons in dialog alert for addorder.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Héctor Eduardo Castro Avalos
QA Contact: Testopia
URL:
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-18 20:49 UTC by Héctor Eduardo Castro Avalos
Modified: 2017-06-14 22:11 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt (1.98 KB, patch)
2016-02-18 20:54 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt (2.12 KB, patch)
2016-02-19 11:36 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt (2.18 KB, patch)
2016-02-22 11:21 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2016-02-18 20:49:54 UTC
A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons.

File: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorder.tt
Comment 1 Héctor Eduardo Castro Avalos 2016-02-18 20:54:34 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-19 11:36:55 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-22 11:21:45 UTC
Created attachment 48276 [details] [review]
Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt

A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons.

To test:
-Add orders to a basket
-Exceed a fund or budget
-Notice about the dialog alert
-Apply patch
-Exceed again and see the new icons

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-02-24 03:26:32 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks much!