Bug 15880 - Serials new frequency link should be a toolbar button
Summary: Serials new frequency link should be a toolbar button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/serials/subscription-fr...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-22 16:57 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15880 - Serials new frequency link should be a toolbar button (4.31 KB, patch)
2016-02-22 18:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15880 - Serials new frequency link should be a toolbar button (4.44 KB, patch)
2016-02-23 16:05 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15880 - Serials new frequency link should be a toolbar button (4.51 KB, patch)
2016-02-29 15:58 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-22 16:57:41 UTC
In Serials -> Frequencies there is a "New frequency" link which should be a Bootstrap-styled toolbar button instead.
Comment 1 Owen Leonard 2016-02-22 18:13:08 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-23 16:05:22 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-29 15:58:37 UTC
Created attachment 48463 [details] [review]
Bug 15880 - Serials new frequency link should be a toolbar button

This patch converts the "new frequency" link to a Bootstrap-style
toolbar button in order to maintain consistency. Also included in this
patch are some other minor markup corrections:

- A colon and space after labels
- A 'Cancel' link instead of a button.
- "Required" classes for a required field.

To test, apply the patch and go to Serials -> Manage frequencies.

- Test the "New frequency" button
- Confirm that the changes to the entry form look correct.

Followed test plan, displays as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-02 00:57:50 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 10:32:58 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 08:59:19 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.