Bug 15881 - Serials new numbering pattern link should be a toolbar button
Summary: Serials new numbering pattern link should be a toolbar button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/serials/subscription-nu...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-22 16:58 UTC by Owen Leonard
Modified: 2017-06-14 22:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15881 - Serials new numbering pattern link should be a toolbar button (5.48 KB, patch)
2016-02-22 18:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15881 - Serials new numbering pattern link should be a toolbar button (5.61 KB, patch)
2016-02-23 16:03 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15881 - Serials new numbering pattern link should be a toolbar button (5.68 KB, patch)
2016-02-29 15:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-22 16:58:58 UTC
In Serials -> Number patterns there is a "New numbering patterns" link which should be a Bootstrap-styled toolbar button instead.
Comment 1 Owen Leonard 2016-02-22 18:26:34 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-23 16:03:02 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-29 15:54:04 UTC
Created attachment 48462 [details] [review]
Bug 15881 - Serials new numbering pattern link should be a toolbar button

This patch converts the "new numbering pattern" link to a
Bootstrap-styled toolbar button for consistency with other pages in
Koha. This patch also includes minor markup corrections:

- Standardizing on the phrase "Numbering patterns" by eliminating the
  occasional use of "number patterns."
- Removing mistaking closing slash on <select>
- Using standard "Cancel" link instead of a button.
- Adding a colon and space after labels.
- Fixing of "no existing patterns" message.

To test, apply the patch and go to Serials -> Numbering patterns

- Confirm that the "New numbering pattern" button looks correct and
  works correctly.
- Confirm that the entry form looks correct and that the cancel link
  works as expected.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-02 00:56:00 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 10:33:57 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 08:59:30 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.