Bug 15884 - Vendor contract deletion warning is incorrectly styled
Summary: Vendor contract deletion warning is incorrectly styled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/aqcontract.pl?op=...
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-23 14:05 UTC by Owen Leonard
Modified: 2017-06-14 22:08 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15884 - Vendor contract deletion warning is incorrectly styled (3.62 KB, patch)
2016-02-23 14:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15884 - Vendor contract deletion warning is incorrectly styled (3.75 KB, patch)
2016-02-23 16:11 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15884 - Vendor contract deletion warning is incorrectly styled (3.82 KB, patch)
2016-02-29 16:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
[3.22.x] Bug 15884 - Vendor contract deletion warning is incorrectly styled (3.57 KB, patch)
2016-03-07 12:47 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-23 14:05:59 UTC
When deleting a contract in  Acquisitions -> Vendor -> Contracts, the deletion confirmation message is not styled with the standard "dialog alert" <div>.
Comment 1 Owen Leonard 2016-02-23 14:23:39 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-23 16:11:04 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-29 16:03:44 UTC
Created attachment 48464 [details] [review]
Bug 15884 - Vendor contract deletion warning is incorrectly styled

When deleting a contract in  Acquisitions -> Vendor -> Contracts, the
deletion confirmation message is not styled with the standard "dialog
alert" <div>. This patch modifies the confirmation markup to match the
standard.

To test, apply the patch and go to Acquisitions -> [ a vendor] ->
Contracts

- Try deleting a contract. The confirmation box should have the standard
  "dialog alert" class.
- Test the 'confirm' and 'cancel' actions and make sure both complete
  correctly.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-02 01:13:59 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 12:47:52 UTC
Created attachment 48745 [details] [review]
[3.22.x] Bug 15884 - Vendor contract deletion warning is incorrectly styled

Patch for 3.22.x
Comment 6 Julian Maurice 2016-03-07 12:48:18 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 7 Frédéric Demians 2016-03-15 09:02:59 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.